issue_comments

Table actions

6 rows where issue = 1294978633 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • to_array to create a dimension as last axis · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1176477717 https://github.com/pydata/xarray/issues/6754#issuecomment-1176477717 https://api.github.com/repos/pydata/xarray/issues/6754 IC_kwDOAMm_X85GH6AV max-sixty 5635139 2022-07-06T17:12:25Z 2022-07-06T17:12:25Z MEMBER

I would say very little. I'm a lazy programmer.

Haha, us both Ray!

I do think that part of laziness is not having to remember too much — so hopefully I can trade you the costs of an extra method call for more consistency!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_array to create a dimension as last axis 1294978633
1176378382 https://github.com/pydata/xarray/issues/6754#issuecomment-1176378382 https://api.github.com/repos/pydata/xarray/issues/6754 IC_kwDOAMm_X85GHhwO raybellwaves 17162724 2022-07-06T15:41:43Z 2022-07-06T15:41:43Z CONTRIBUTOR

What's the advantage of this over the transpose call?

I would say very little. I'm a lazy programmer.

I appreciate the arguments here of not blending methods which could make them more prone to bugs. I doubt there's any noticeable overhead of computation cost with the extra transpose call.

Welcome to close.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_array to create a dimension as last axis 1294978633
1176368145 https://github.com/pydata/xarray/issues/6754#issuecomment-1176368145 https://api.github.com/repos/pydata/xarray/issues/6754 IC_kwDOAMm_X85GHfQR dcherian 2448579 2022-07-06T15:32:12Z 2022-07-06T15:32:12Z MEMBER

@max-sixty yeah that's valid.

@raybellwaves ds.to_array(dim="variable").transpose("latitude", "longitude", "variable") could be written as ds.to_array(dim="variable").transpose(..., "variable") which generalizes better

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_array to create a dimension as last axis 1294978633
1175783623 https://github.com/pydata/xarray/issues/6754#issuecomment-1175783623 https://api.github.com/repos/pydata/xarray/issues/6754 IC_kwDOAMm_X85GFQjH max-sixty 5635139 2022-07-06T05:01:48Z 2022-07-06T05:01:48Z MEMBER

What's the advantage of this over the transpose call?

The transpose approach is more modular, since it takes advantage of the orthogonality of the methods — i.e. we have one method for all usages, rather than kwargs in lots of methods.

We've also managed to have axis as a hidden implentation detail, and this would start exposing it.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_array to create a dimension as last axis 1294978633
1175730605 https://github.com/pydata/xarray/issues/6754#issuecomment-1175730605 https://api.github.com/repos/pydata/xarray/issues/6754 IC_kwDOAMm_X85GFDmt raybellwaves 17162724 2022-07-06T03:12:52Z 2022-07-06T03:12:52Z CONTRIBUTOR

We could follow the axis kwarg to DataArray.expand_dims as precedent. It specifies the axis number for the new dimension.

Thanks. Made a PR before seeing your comment. Welcome to chime in on the PR

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_array to create a dimension as last axis 1294978633
1175723941 https://github.com/pydata/xarray/issues/6754#issuecomment-1175723941 https://api.github.com/repos/pydata/xarray/issues/6754 IC_kwDOAMm_X85GFB-l dcherian 2448579 2022-07-06T02:58:27Z 2022-07-06T02:58:27Z MEMBER

We could follow the axis kwarg to DataArray.expand_dims as precedent. It specifies the axis number for the new dimension.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_array to create a dimension as last axis 1294978633

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);