issue_comments

Table actions

8 rows where issue = 1292091752 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix `DataArrayRolling.__iter__` with `center=True` · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1184726434 https://github.com/pydata/xarray/pull/6744#issuecomment-1184726434 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85GnX2i dcherian 2448579 2022-07-14T17:40:56Z 2022-07-14T17:40:56Z MEMBER

Thanks @headtr1ck 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1183595836 https://github.com/pydata/xarray/pull/6744#issuecomment-1183595836 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85GjD08 headtr1ck 43316012 2022-07-13T19:27:48Z 2022-07-13T19:27:48Z COLLABORATOR

We could merge this PR after a final review. For now it fixes the bug in the issue.

For a DatasetRolling.iter support we could either open a new issue or just wait until someone requests it :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1182201709 https://github.com/pydata/xarray/pull/6744#issuecomment-1182201709 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85Gdvdt headtr1ck 43316012 2022-07-12T18:26:25Z 2022-07-12T18:26:25Z COLLABORATOR

Would you mind moving the first commit to a new PR that we can merge quickly please? It'll be easier to see any new tests you've added then

I'm fast in adding scope kreep xD Done in https://github.com/pydata/xarray/pull/6777

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1182169308 https://github.com/pydata/xarray/pull/6744#issuecomment-1182169308 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85Gdnjc dcherian 2448579 2022-07-12T18:12:52Z 2022-07-12T18:12:52Z MEMBER

Would you mind moving the first commit to a new PR that we can merge quickly please? It'll be easier to see any new tests you've added then

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1175865107 https://github.com/pydata/xarray/pull/6744#issuecomment-1175865107 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85GFkcT headtr1ck 43316012 2022-07-06T07:14:24Z 2022-07-06T07:14:24Z COLLABORATOR

Btw: this issue https://github.com/pydata/xarray/issues/6749 is the reason why it currently does not work for datasets.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1172945231 https://github.com/pydata/xarray/pull/6744#issuecomment-1172945231 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85F6blP headtr1ck 43316012 2022-07-02T18:57:56Z 2022-07-02T18:57:56Z COLLABORATOR

But maybe that is already too complicated.

Anyone has an idea how to get this: counts = window.count(dim=self.dim[0]) window = window.where(counts >= self.min_periods) operate only on variables that contain self.dim[0]? If possible in a way that works both on DataArrays and Datasets :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1172943712 https://github.com/pydata/xarray/pull/6744#issuecomment-1172943712 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85F6bNg headtr1ck 43316012 2022-07-02T18:46:17Z 2022-07-02T18:47:55Z COLLABORATOR

Would it be useful to add a function has_dim that returns e.g.: xr.DataArray([], dims="x").has_dim("x") #-> xr.DataArray(True) xr.Dataset({"x": ("x", []), "y": ("y", [])}).has_dim("x") # -> xr.Dataset({"x": True, "y": False}) ? Since these are scalar (no dims) they are nicely broadcastable and can be used in xarray pipelines.

But maybe this already works easily and I just don't know about it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752
1172943171 https://github.com/pydata/xarray/pull/6744#issuecomment-1172943171 https://api.github.com/repos/pydata/xarray/issues/6744 IC_kwDOAMm_X85F6bFD headtr1ck 43316012 2022-07-02T18:42:03Z 2022-07-02T18:42:03Z COLLABORATOR

I am now trying to get this to work for Datasets as well. But the check of min_periods fails for variables that do not contain the rolling dim, since the count is 1. Any idea how to solve this issue?

Is there a way to get a boolean, scalar DataArray/set that contains this information?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix `DataArrayRolling.__iter__` with `center=True` 1292091752

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);