issue_comments

Table actions

6 rows where issue = 1290524064 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • some private imports broken on main · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1171616498 https://github.com/pydata/xarray/issues/6741#issuecomment-1171616498 https://api.github.com/repos/pydata/xarray/issues/6741 IC_kwDOAMm_X85F1XLy headtr1ck 43316012 2022-06-30T19:52:57Z 2022-06-30T19:52:57Z COLLABORATOR

Another example is that asfreq has moved downstream a little and is no longer available on Resample either, can probably break something as well.

It was moved because it actually didn't work in the baseclass ;) So I don't think anyone has ever used that.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   some private imports broken on main 1290524064
1171613138 https://github.com/pydata/xarray/issues/6741#issuecomment-1171613138 https://api.github.com/repos/pydata/xarray/issues/6741 IC_kwDOAMm_X85F1WXS Illviljan 14371165 2022-06-30T19:48:38Z 2022-06-30T19:49:41Z MEMBER

Another example is that asfreq has moved downstream a little and is no longer available on Resample either, can probably break something as well.

The docstring also warns to use this class directly since it behaves as an incomplete base class. https://github.com/pydata/xarray/blob/725258e27fff26a23bf978ca99da9c7a6e98cb4c/xarray/core/resample.py#L20-L24

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   some private imports broken on main 1290524064
1171598454 https://github.com/pydata/xarray/issues/6741#issuecomment-1171598454 https://api.github.com/repos/pydata/xarray/issues/6741 IC_kwDOAMm_X85F1Sx2 Illviljan 14371165 2022-06-30T19:31:40Z 2022-06-30T19:31:40Z MEMBER 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   some private imports broken on main 1290524064
1171582001 https://github.com/pydata/xarray/issues/6741#issuecomment-1171582001 https://api.github.com/repos/pydata/xarray/issues/6741 IC_kwDOAMm_X85F1Owx headtr1ck 43316012 2022-06-30T19:15:05Z 2022-06-30T19:15:05Z COLLABORATOR

On the plus side, with the current implementation we probably save a few ms import time xD.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   some private imports broken on main 1290524064
1171580196 https://github.com/pydata/xarray/issues/6741#issuecomment-1171580196 https://api.github.com/repos/pydata/xarray/issues/6741 IC_kwDOAMm_X85F1OUk headtr1ck 43316012 2022-06-30T19:12:45Z 2022-06-30T19:12:45Z COLLABORATOR

It was a semi-incidential change. These modules are now only imported when required (i.e. calling DataArray.rolling ), I didn't think anyone would actually use these classes directly.

The modules can either be imported at DataArray/set module level directly again, or we could add a breaking change note.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   some private imports broken on main 1290524064
1171576721 https://github.com/pydata/xarray/issues/6741#issuecomment-1171576721 https://api.github.com/repos/pydata/xarray/issues/6741 IC_kwDOAMm_X85F1NeR aulemahal 20629530 2022-06-30T19:08:28Z 2022-06-30T19:08:28Z CONTRIBUTOR

To add details, I suspect this commit as the culprit: https://github.com/headtr1ck/xarray/commit/cd2f2b247cf6e1c68c7db6e92100898272fb0e1a

It removes a direct import of the core.resample submodule in core.dataarray and moves it to the "Type checking" imports. Thus, importing xarray (import xarray as xr), does not trigger an explicit import of resample anymore.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   some private imports broken on main 1290524064

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);