issue_comments

Table actions

7 rows where issue = 1275993190 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Add `Dataset.dtypes` property · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1163305223 https://github.com/pydata/xarray/pull/6706#issuecomment-1163305223 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FVqEH max-sixty 5635139 2022-06-22T16:01:53Z 2022-06-22T16:01:53Z MEMBER

Thank you v much @headtr1ck !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190
1160668211 https://github.com/pydata/xarray/pull/6706#issuecomment-1160668211 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FLmQz TomNicholas 35968931 2022-06-20T16:58:02Z 2022-06-21T15:21:54Z MEMBER

Good question, I'm not sure. They are not intended to be created by users IIUC, it's more like a "view" of the underlying coords. Does anyone have a view?

My understanding of these classes is that they are just slightly more complex mapping-like objects that we return instead of returning dicts in some cases. Sometimes they are intended to be immutable views and sometimes mutable IIUC. But I agree that they aren't intended to be instantiated directly by users.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190
1160665041 https://github.com/pydata/xarray/pull/6706#issuecomment-1160665041 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FLlfR max-sixty 5635139 2022-06-20T16:53:12Z 2022-06-20T16:53:12Z MEMBER

Is it intentional that DataArrayCoordinates and DatasetCoordinates are not part of api?

Good question, I'm not sure. They are not intended to be created by users IIUC, it's more like a "view" of the underlying coords. Does anyone have a view?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190
1160660440 https://github.com/pydata/xarray/pull/6706#issuecomment-1160660440 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FLkXY headtr1ck 43316012 2022-06-20T16:46:27Z 2022-06-20T16:46:27Z COLLABORATOR

Is it intentional that DataArrayCoordinates and DatasetCoordinates are not part of api?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190
1160644120 https://github.com/pydata/xarray/pull/6706#issuecomment-1160644120 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FLgYY dcherian 2448579 2022-06-20T16:26:23Z 2022-06-20T16:26:58Z MEMBER

See related discussion here: https://github.com/pydata/xarray/issues/1699

I like the idea of .dtypes only listing data variables and coords.dtypes for the rest. This nicely generalizes to DataArray.coords.dtypes

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190
1159800145 https://github.com/pydata/xarray/pull/6706#issuecomment-1159800145 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FISVR headtr1ck 43316012 2022-06-19T19:50:43Z 2022-06-19T19:50:43Z COLLABORATOR

My inkling would be only data variables, given that's all we iterate over on a Dataset.

I would have thought the same. I have updated it now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190
1159784167 https://github.com/pydata/xarray/pull/6706#issuecomment-1159784167 https://api.github.com/repos/pydata/xarray/issues/6706 IC_kwDOAMm_X85FIObn max-sixty 5635139 2022-06-19T17:54:31Z 2022-06-19T17:54:31Z MEMBER

Great!

My inkling would be only data variables, given that's all we iterate over on a Dataset. We could also add this into the DatasetCoords / DataArrayCoords for completeness.

Any other thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add `Dataset.dtypes` property 1275993190

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);