issue_comments

Table actions

10 rows where issue = 1275752720 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Future of `DataArray.rename` · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1168410514 https://github.com/pydata/xarray/issues/6704#issuecomment-1168410514 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FpIeS benbovy 4160723 2022-06-28T08:34:42Z 2022-06-28T08:34:42Z MEMBER

Should rename_dims also rename indexes (dimension coordinates)?

Sorry I think I misunderstood the question. If that means "should rename_dims also rename the (dimension) coordinates", then I think the answer should be no. With the explicit indexes refactor coordinates and indexes are less tightly coupled, i.e., in the mid/long term we want to drop the concept of a "dimension coordinate with an implicit index". So I think rename_dims should only rename dimensions (and update indexes metadata accordingly, cf. my previous comment).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1166980787 https://github.com/pydata/xarray/issues/6704#issuecomment-1166980787 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85Fjraz benbovy 4160723 2022-06-27T07:23:24Z 2022-06-27T07:25:13Z MEMBER

Should rename_dims also rename indexes (dimension coordinates)?

Yes, renaming dimensions and/or coordinates should be properly handled by indexes. Xarray's Index abstract class provides a rename method that may (should) be implemented in subclasses.

For example, PandasIndex and PandasMultiIndex both have a dim attribute that must match the dimension name (this attribute is required as in a near future it will be possible to set indexes for non-dimension coordinates).

PandasIndex.rename (PandasMultiIndex.rename) also renames the underlying pandas index (levels) according to the new coordinate name(s).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1163345547 https://github.com/pydata/xarray/issues/6704#issuecomment-1163345547 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FVz6L shoyer 1217238 2022-06-22T16:31:33Z 2022-06-22T16:31:33Z MEMBER

Dataset.rename does both variables and dimensions. That seems useful in many cases. I think it also makes more sense than Dataset.drop does, given that variables and dimensions often use the same names -- whereas drop mixed up variable names and index values.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1163311176 https://github.com/pydata/xarray/issues/6704#issuecomment-1163311176 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FVrhI max-sixty 5635139 2022-06-22T16:06:13Z 2022-06-22T16:06:13Z MEMBER

As discussed on the call: - We'd like to move to .rename and .rename_vars as separate methods on DataArray; the latter renaming coords. - We would "soft-deprecate" .rename for renaming coords — i.e. remove documentation, but not give any warnings, at least for a while. This was a successful approach for .drop. - .rename_vars is a slightly odd name given there are only coords. But it's consistent with xr.Dataset.

After the call, I realize that I didn't mention that Dataset.rename is a synonym for Dataset.rename_vars. Would be also soft deprecate Dataset.rename?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1163292851 https://github.com/pydata/xarray/issues/6704#issuecomment-1163292851 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FVnCz shoyer 1217238 2022-06-22T15:52:12Z 2022-06-22T15:52:12Z MEMBER

Should we call it rename_vars or rename_coords?

The later might make more sense, but then it wouldn't mirror Dataset.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1163290603 https://github.com/pydata/xarray/issues/6704#issuecomment-1163290603 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FVmfr mathause 10194086 2022-06-22T15:50:32Z 2022-06-22T15:50:32Z MEMBER

There is also anther issue discussing this: #4825

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1161952023 https://github.com/pydata/xarray/issues/6704#issuecomment-1161952023 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FQfsX max-sixty 5635139 2022-06-21T15:59:22Z 2022-06-21T15:59:22Z MEMBER

I feel honored thanks! But given that I will become a father any day now, I don't think I will be able to join regularly...

Congrats on the forthcoming arrival!

Ofc, no stress if you can't make the meeting, and obv zero stress if you can't make lots of them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1161313340 https://github.com/pydata/xarray/issues/6704#issuecomment-1161313340 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FODw8 headtr1ck 43316012 2022-06-21T06:20:54Z 2022-06-21T06:20:54Z COLLABORATOR

I feel honored thanks! But given that I will become a father any day now, I don't think I will be able to join regularly...

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1159785204 https://github.com/pydata/xarray/issues/6704#issuecomment-1159785204 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FIOr0 keewis 14808389 2022-06-19T18:02:20Z 2022-06-19T20:09:04Z MEMBER

that's #4001

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1159784960 https://github.com/pydata/xarray/issues/6704#issuecomment-1159784960 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FIOoA max-sixty 5635139 2022-06-19T18:00:50Z 2022-06-19T18:00:50Z MEMBER

This is the sort of thing we can discuss briefly on our dev call — which you would be more than welcome to attend and participate in @headtr1ck.

It's at 8.30AM PT every second Wednesday, including this coming Wednesday. I think there's an issue about it (though am on a plane wifi connection so currently difficult to search...). Unfortunately I've been poor at attendance recently given my schedule, but I have been trying to rearrange things so I can start attending again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);