issue_comments

Table actions

2 rows where issue = 1268821199 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Rolling.argmin() and Rolling.argmax() over multiple dimensions does not work · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1158434252 https://github.com/pydata/xarray/issues/6691#issuecomment-1158434252 https://api.github.com/repos/pydata/xarray/issues/6691 IC_kwDOAMm_X85FDE3M AlxLhrNc 90059220 2022-06-17T02:54:27Z 2022-06-17T02:54:27Z NONE

Thank you for upgrading this question. Using keewis suggestion:

We could try to work around this by wrapping argmin and argmax in a function that ravels / unravels the reduce dimensions.

I had a look into numpy documentation and came up with a work around like so: ```python import numpy as np, xarray as xr

arr = xr.DataArray(np.ones((5,6,7))) arr[1,3,2], arr[3,1,4] = 0, 2

print('Values:',arr.min(), arr.max())

min_pos = np.concatenate(np.where(arr == arr.min())) max_pos = np.concatenate(np.where(arr == arr.max())) print('Indexes on nD:', min_pos, max_pos) ``` It is not perfect I suppose but it is doing the job for now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling.argmin() and Rolling.argmax() over multiple dimensions does not work 1268821199
1153613732 https://github.com/pydata/xarray/issues/6691#issuecomment-1153613732 https://api.github.com/repos/pydata/xarray/issues/6691 IC_kwDOAMm_X85Ewr-k keewis 14808389 2022-06-13T08:14:43Z 2022-06-13T08:14:43Z MEMBER

for reference, here's the MCVE: ```python import xarray as xr

ds = xr.tutorial.open_dataset("air_temperature") n = 3

window_size = {name: n for name in ["lat", "lon"]} window = ds.rolling(window_size, center=True) peak_min = window.argmin() peak_max = window.argmax() ```

As far as I can tell, the reason is that np.argmin does not support more than one axis (the actual call is here).

We could try to work around this by wrapping argmin and argmax in a function that ravels / unravels the reduce dimensions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rolling.argmin() and Rolling.argmax() over multiple dimensions does not work 1268821199

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);