issue_comments

Table actions

3 rows where issue = 1268697316 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix Dataset.where with drop=True and mixed dims · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1153303950 https://github.com/pydata/xarray/pull/6690#issuecomment-1153303950 https://api.github.com/repos/pydata/xarray/issues/6690 IC_kwDOAMm_X85EvgWO max-sixty 5635139 2022-06-12T22:06:47Z 2022-06-12T22:06:47Z MEMBER

This looks great! Thanks @headtr1ck .

I don't think this is doing any additional passes of the data — it's just computing metadata like dims — so I don't think it strictly needs a benchmark. (Though never opposed to more benchmarks...).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix Dataset.where with drop=True and mixed dims 1268697316
1153294567 https://github.com/pydata/xarray/pull/6690#issuecomment-1153294567 https://api.github.com/repos/pydata/xarray/issues/6690 IC_kwDOAMm_X85EveDn headtr1ck 43316012 2022-06-12T21:16:10Z 2022-06-12T21:16:10Z COLLABORATOR

Is this a breaking changes if users might expect the old behavior?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix Dataset.where with drop=True and mixed dims 1268697316
1153291119 https://github.com/pydata/xarray/pull/6690#issuecomment-1153291119 https://api.github.com/repos/pydata/xarray/issues/6690 IC_kwDOAMm_X85EvdNv headtr1ck 43316012 2022-06-12T20:57:54Z 2022-06-12T20:57:54Z COLLABORATOR

Do you think a benchmark is required for this new method? I actually did not check the runtime yet...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix Dataset.where with drop=True and mixed dims 1268697316

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);