issue_comments

Table actions

4 rows where issue = 1255359858 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • pdyap version dependent client.open_url call · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1158138309 https://github.com/pydata/xarray/pull/6656#issuecomment-1158138309 https://api.github.com/repos/pydata/xarray/issues/6656 IC_kwDOAMm_X85FB8nF dcherian 2448579 2022-06-16T21:17:25Z 2022-06-16T21:17:25Z MEMBER

Thanks @observingClouds . We could definitely improve test coverage here if you're up for making some more contributions in the future.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pdyap version dependent client.open_url call 1255359858
1146453489 https://github.com/pydata/xarray/pull/6656#issuecomment-1146453489 https://api.github.com/repos/pydata/xarray/issues/6656 IC_kwDOAMm_X85EVX3x observingClouds 43613877 2022-06-03T23:36:54Z 2022-06-03T23:37:34Z CONTRIBUTOR

Our tests on min-all-deps are running with pydap 3.2.2 but were passing. Was the test xfailed? If so can we remove it.

Actually, the general unit test should fail but the specific tests are skipped. Only when the flag --run-network-tests is provided to pytest the tests run and would have failed in the past.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pdyap version dependent client.open_url call 1255359858
1146169095 https://github.com/pydata/xarray/pull/6656#issuecomment-1146169095 https://api.github.com/repos/pydata/xarray/issues/6656 IC_kwDOAMm_X85EUScH dcherian 2448579 2022-06-03T16:47:11Z 2022-06-03T16:47:11Z MEMBER

Our tests on min-all-deps are running with pydap 3.2.2 but were passing. Was the test xfailed? If so can we remove it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pdyap version dependent client.open_url call 1255359858
1143316526 https://github.com/pydata/xarray/pull/6656#issuecomment-1143316526 https://api.github.com/repos/pydata/xarray/issues/6656 IC_kwDOAMm_X85EJaAu observingClouds 43613877 2022-06-01T08:50:43Z 2022-06-01T08:50:43Z CONTRIBUTOR

Shall we raise a warning in case verify and/or user_charset are given and the used pydap version is older than 3.0.0? Or is it fine to just ignore those arguments in this case without warning the user?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pdyap version dependent client.open_url call 1255359858

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);