issue_comments

Table actions

4 rows where issue = 125386942 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix #709 · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
169857697 https://github.com/pydata/xarray/pull/710#issuecomment-169857697 https://api.github.com/repos/pydata/xarray/issues/710 MDEyOklzc3VlQ29tbWVudDE2OTg1NzY5Nw== tkanmae 305196 2016-01-08T01:13:28Z 2016-01-08T01:13:28Z CONTRIBUTOR

My bad.. I put that back.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #709 125386942
169856254 https://github.com/pydata/xarray/pull/710#issuecomment-169856254 https://api.github.com/repos/pydata/xarray/issues/710 MDEyOklzc3VlQ29tbWVudDE2OTg1NjI1NA== shoyer 1217238 2016-01-08T01:06:11Z 2016-01-08T01:06:11Z MEMBER

it would be good to add a quick note in "what's new" also to mention the bug fix. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #709 125386942
169855724 https://github.com/pydata/xarray/pull/710#issuecomment-169855724 https://api.github.com/repos/pydata/xarray/issues/710 MDEyOklzc3VlQ29tbWVudDE2OTg1NTcyNA== tkanmae 305196 2016-01-08T01:02:26Z 2016-01-08T01:02:26Z CONTRIBUTOR

I added a regression test for #709 in BaseNetCDF4. I confirmed that it fails before and passes after applying the fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #709 125386942
169761598 https://github.com/pydata/xarray/pull/710#issuecomment-169761598 https://api.github.com/repos/pydata/xarray/issues/710 MDEyOklzc3VlQ29tbWVudDE2OTc2MTU5OA== shoyer 1217238 2016-01-07T18:18:27Z 2016-01-07T18:18:27Z MEMBER

Thanks for tracking this down! Could you please add a regression test -- something that fails before but passes afterwards? BaseNetCDF4Test looks like the right place: https://github.com/pydata/xarray/blob/eb8d179d344599f68a304e0ca1128398c235a81c/xray/test/test_backends.py#L408

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix #709 125386942

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);