issue_comments

Table actions

10 rows where issue = 1249350841 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Fix kwargs used for extrapolation in docs · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1143178545 https://github.com/pydata/xarray/pull/6639#issuecomment-1143178545 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85EI4Ux Illviljan 14371165 2022-06-01T06:42:24Z 2022-06-01T06:42:24Z MEMBER

Merged, thanks @DoktorScience !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1142376037 https://github.com/pydata/xarray/pull/6639#issuecomment-1142376037 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85EF0Zl dcherian 2448579 2022-05-31T16:45:45Z 2022-05-31T16:45:45Z MEMBER

Thanks @DoktorScience and @pums974 !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1141913482 https://github.com/pydata/xarray/pull/6639#issuecomment-1141913482 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85EEDeK pums974 1005109 2022-05-31T09:44:54Z 2022-05-31T09:44:54Z CONTRIBUTOR

Yep this look good to me too. Thank you

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1141699498 https://github.com/pydata/xarray/pull/6639#issuecomment-1141699498 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85EDPOq lstngr 40182387 2022-05-31T06:02:28Z 2022-05-31T06:02:28Z CONTRIBUTOR

Thank you for the heads-up @Illviljan. Should be good now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1141486973 https://github.com/pydata/xarray/pull/6639#issuecomment-1141486973 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85ECbV9 Illviljan 14371165 2022-05-30T21:29:01Z 2022-05-30T21:29:01Z MEMBER

@DoktorScience could you merge main and fix the conflicts? I think we can merge this afterwards.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1140409653 https://github.com/pydata/xarray/pull/6639#issuecomment-1140409653 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85D-UU1 lstngr 40182387 2022-05-29T09:17:49Z 2022-05-29T09:17:49Z CONTRIBUTOR

@pums974 You maybe have an opinion on the accuracy of this PR, since you originally implemented this behavior?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1139582688 https://github.com/pydata/xarray/pull/6639#issuecomment-1139582688 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85D7Kbg lstngr 40182387 2022-05-27T12:41:56Z 2022-05-27T12:41:56Z CONTRIBUTOR

Hopefully this looks better: it now states that interp1d may be called when preforming multivariate interpolation. Let me know if you think the extended summaries can be improved.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1139081553 https://github.com/pydata/xarray/pull/6639#issuecomment-1139081553 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85D5QFR Illviljan 14371165 2022-05-26T21:33:31Z 2022-05-26T21:33:31Z MEMBER

Sounds good to me!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1138892993 https://github.com/pydata/xarray/pull/6639#issuecomment-1138892993 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85D4iDB lstngr 40182387 2022-05-26T18:37:32Z 2022-05-26T18:37:32Z CONTRIBUTOR

Right now, the docstring only suggests different interpolation may be used depending on the input, but typically refers to "1-dimensional" vs "multi-dimensional" arrays. I would do it this way:

  1. an extended summary is added, explaining when scipy.interpolate.interp1d or scipy.interpolate.interpnd are used,
  2. modify the parameters section to refer to arguments accepted when interp1d or interpnd is used.

Does that look alright to you?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841
1138849436 https://github.com/pydata/xarray/pull/6639#issuecomment-1138849436 https://api.github.com/repos/pydata/xarray/issues/6639 IC_kwDOAMm_X85D4Xac Illviljan 14371165 2022-05-26T17:49:31Z 2022-05-26T17:49:31Z MEMBER

I wonder if the docstrings can be improved or do you think the docstrings for interp are clear about this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix kwargs used for extrapolation in docs 1249350841

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);