issue_comments

Table actions

3 rows where issue = 124578622 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Allow empty DataFrame in Dataset construction · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
168369127 https://github.com/pydata/xarray/pull/698#issuecomment-168369127 https://api.github.com/repos/pydata/xarray/issues/698 MDEyOklzc3VlQ29tbWVudDE2ODM2OTEyNw== shoyer 1217238 2016-01-02T07:28:33Z 2016-01-02T07:28:33Z MEMBER

This is definitely more consistent -- for example, imagine slicing a DataFrame into different sizes, converting each group into a Dataset and then concatenation.

Thanks! You get big kudos for deleting code but adding a test :).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty DataFrame in Dataset construction 124578622
168369005 https://github.com/pydata/xarray/pull/698#issuecomment-168369005 https://api.github.com/repos/pydata/xarray/issues/698 MDEyOklzc3VlQ29tbWVudDE2ODM2OTAwNQ== max-sixty 5635139 2016-01-02T07:23:19Z 2016-01-02T07:23:19Z MEMBER

The empty <-> empty does make sense actually.

I think either would be OK...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty DataFrame in Dataset construction 124578622
168368633 https://github.com/pydata/xarray/pull/698#issuecomment-168368633 https://api.github.com/repos/pydata/xarray/issues/698 MDEyOklzc3VlQ29tbWVudDE2ODM2ODYzMw== shoyer 1217238 2016-01-02T07:06:04Z 2016-01-02T07:06:04Z MEMBER

I guess I thought an empty DataFrame should correspond to an empty Dataset? I agree that this makes more sense, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow empty DataFrame in Dataset construction 124578622

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);