issue_comments

Table actions

5 rows where issue = 1245726154 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Literal type of engine argument incompatible with custom backends · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1136402435 https://github.com/pydata/xarray/issues/6632#issuecomment-1136402435 https://api.github.com/repos/pydata/xarray/issues/6632 IC_kwDOAMm_X85DvCAD headtr1ck 43316012 2022-05-24T20:31:23Z 2022-05-24T20:31:23Z COLLABORATOR

Ok, let's keep this issue open for a bit in case someone still finds a solution. But we should go back to Str before releasing the next version.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Literal type of engine argument incompatible with custom backends 1245726154
1136399588 https://github.com/pydata/xarray/issues/6632#issuecomment-1136399588 https://api.github.com/repos/pydata/xarray/issues/6632 IC_kwDOAMm_X85DvBTk Illviljan 14371165 2022-05-24T20:27:54Z 2022-05-24T20:27:54Z MEMBER

Yeah, reverting to Str seems to be the most straightforward way. It's unfortunate though Literals are really nice. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Literal type of engine argument incompatible with custom backends 1245726154
1136377850 https://github.com/pydata/xarray/issues/6632#issuecomment-1136377850 https://api.github.com/repos/pydata/xarray/issues/6632 IC_kwDOAMm_X85Du7_6 headtr1ck 43316012 2022-05-24T20:02:11Z 2022-05-24T20:02:11Z COLLABORATOR

Or we could just have a global variable like SUPPORTED_BACKENDS: List[str] = Literal['netcdf4', 'zarr'] which is appended to when a user registers a new backend?

If you know how that works statically, I don't see a way to do that. You can only get dynamic content from static types and not the other way around.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 1,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Literal type of engine argument incompatible with custom backends 1245726154
1136280672 https://github.com/pydata/xarray/issues/6632#issuecomment-1136280672 https://api.github.com/repos/pydata/xarray/issues/6632 IC_kwDOAMm_X85DukRg TomNicholas 35968931 2022-05-24T18:11:39Z 2022-05-24T18:11:39Z MEMBER

Or we could just have a global variable like SUPPORTED_BACKENDS: List[str] = Literal['netcdf4', 'zarr'] which is appended to when a user registers a new backend?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Literal type of engine argument incompatible with custom backends 1245726154
1136272481 https://github.com/pydata/xarray/issues/6632#issuecomment-1136272481 https://api.github.com/repos/pydata/xarray/issues/6632 IC_kwDOAMm_X85DuiRh TomNicholas 35968931 2022-05-24T18:03:28Z 2022-05-24T18:03:28Z MEMBER

I don't think we should be using a Literal for something that a user is supposed to be able to extend anyway surely? IIUC a user is supposed to be define their own backend and use it to open a dataset, all without ever needing to add it to any official list within the xarray repo?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Literal type of engine argument incompatible with custom backends 1245726154

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);