issue_comments

Table actions

1 row where issue = 123971294 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • to_masked_array should have an option to always return array · 1 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
167404601 https://github.com/pydata/xarray/issues/684#issuecomment-167404601 https://api.github.com/repos/pydata/xarray/issues/684 MDEyOklzc3VlQ29tbWVudDE2NzQwNDYwMQ== shoyer 1217238 2015-12-27T12:04:43Z 2015-12-27T12:04:43Z MEMBER

Hmm. We currently use np.ma.masked_where to construct a masked array, which sometimes creates masked arrays with as a scalar mask (mask=False):

```

np.ma.masked_where(np.arange(3) < -10, np.arange(3)) masked_array(data = [0 1 2], mask = False, fill_value = 999999) ```

I'm not entirely sure if these are actually valid masked arrays or not (maybe @jhamman or someone who uses masked arrays more often than me would know?), but I agree that it's not very useful for xray to return them. An alternative would be to use the MaskedArray constructor, which does not have this issue:

```

np.ma.MaskedArray(np.arange(3), np.arange(3) < -10) masked_array(data = [0 1 2], mask = [False False False], fill_value = 999999) ```

This seems like better behavior to me.

If you're interested in putting together a fix, here's the relevant place in xray: https://github.com/xray/xray/blob/1c908bebff4c621c959d1bc8f78b4e4298ee87ce/xray/core/dataarray.py#L993

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_masked_array should have an option to always return array 123971294

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);