issue_comments

Table actions

3 rows where issue = 1233717699 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • `polyval` with timedelta64 coordinates produces wrong results · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1124868221 https://github.com/pydata/xarray/issues/6597#issuecomment-1124868221 https://api.github.com/repos/pydata/xarray/issues/6597 IC_kwDOAMm_X85DDCB9 headtr1ck 43316012 2022-05-12T11:18:14Z 2022-05-12T11:18:14Z COLLABORATOR

Ok, the first idea does not work since values is a numpy array.

The second idea should work, so this is a bug. It seems that polyval does not work with timedeltas, I will look into that.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `polyval` with timedelta64 coordinates produces wrong results 1233717699
1124863541 https://github.com/pydata/xarray/issues/6597#issuecomment-1124863541 https://api.github.com/repos/pydata/xarray/issues/6597 IC_kwDOAMm_X85DDA41 malmans2 22245117 2022-05-12T11:12:39Z 2022-05-12T11:12:39Z CONTRIBUTOR

Thanks - I think I might be misunderstanding how the new implementation works. I tried the following changes, but both of them return an error: python xr.polyval(values - values[0], polyfit_coefficients) Traceback (most recent call last): File "/Users/mattia/MyGit/test.py", line 31, in <module> xr.polyval(values - values[0], polyfit_coefficients) File "/Users/mattia/MyGit/xarray/xarray/core/computation.py", line 1908, in polyval coord = _ensure_numeric(coord) # type: ignore # https://github.com/python/mypy/issues/1533 ? File "/Users/mattia/MyGit/xarray/xarray/core/computation.py", line 1949, in _ensure_numeric return to_floatable(data) File "/Users/mattia/MyGit/xarray/xarray/core/computation.py", line 1939, in to_floatable x.data, ValueError: cannot include dtype 'm' in a buffer

python xr.polyval(azimuth_time.coords["azimuth_time"], polyfit_coefficients) Traceback (most recent call last): File "/Users/mattia/MyGit/test.py", line 31, in <module> xr.polyval(azimuth_time.coords["azimuth_time"], polyfit_coefficients) File "/Users/mattia/MyGit/xarray/xarray/core/computation.py", line 1908, in polyval coord = _ensure_numeric(coord) # type: ignore # https://github.com/python/mypy/issues/1533 ? File "/Users/mattia/MyGit/xarray/xarray/core/computation.py", line 1949, in _ensure_numeric return to_floatable(data) File "/Users/mattia/MyGit/xarray/xarray/core/computation.py", line 1938, in to_floatable data=datetime_to_numeric( File "/Users/mattia/MyGit/xarray/xarray/core/duck_array_ops.py", line 434, in datetime_to_numeric array = array - offset numpy.core._exceptions._UFuncBinaryResolutionError: ufunc 'subtract' cannot use operands with types dtype('<m8[ns]') and dtype('<M8[D]')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `polyval` with timedelta64 coordinates produces wrong results 1233717699
1124854798 https://github.com/pydata/xarray/issues/6597#issuecomment-1124854798 https://api.github.com/repos/pydata/xarray/issues/6597 IC_kwDOAMm_X85DC-wO headtr1ck 43316012 2022-05-12T11:02:55Z 2022-05-12T11:04:28Z COLLABORATOR

As listed in breaking changes, the new polyval algorithm uses the values of the coord argument and not the index coordinate.

Your coordinate is a Timedelta values -values[0], try using that directly or azimuth_time.coords["azimuth_time"].

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `polyval` with timedelta64 coordinates produces wrong results 1233717699

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);