issue_comments
6 rows where issue = 1226272301 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
issue 1
- 32- vs 64-bit coordinates coordinates in where() · 6 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
1260551056 | https://github.com/pydata/xarray/issues/6573#issuecomment-1260551056 | https://api.github.com/repos/pydata/xarray/issues/6573 | IC_kwDOAMm_X85LInuQ | benbovy 4160723 | 2022-09-28T08:17:09Z | 2022-09-28T08:17:09Z | MEMBER | I also like the idea of alignment with some tolerance. There is an open PR #4489, which needs to be reworked in the context of the explicit index refactor. Alternatively to a new kwarg we could add an index build option, e.g., |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
32- vs 64-bit coordinates coordinates in where() 1226272301 | |
1127517369 | https://github.com/pydata/xarray/issues/6573#issuecomment-1127517369 | https://api.github.com/repos/pydata/xarray/issues/6573 | IC_kwDOAMm_X85DNIy5 | forman 206773 | 2022-05-16T10:50:06Z | 2022-05-16T10:50:06Z | NONE |
I like that. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
32- vs 64-bit coordinates coordinates in where() 1226272301 | |
1119082834 | https://github.com/pydata/xarray/issues/6573#issuecomment-1119082834 | https://api.github.com/repos/pydata/xarray/issues/6573 | IC_kwDOAMm_X85Cs9lS | dcherian 2448579 | 2022-05-05T21:57:58Z | 2022-05-05T21:57:58Z | MEMBER | Maybe we should add an explicit |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
32- vs 64-bit coordinates coordinates in where() 1226272301 | |
1119076731 | https://github.com/pydata/xarray/issues/6573#issuecomment-1119076731 | https://api.github.com/repos/pydata/xarray/issues/6573 | IC_kwDOAMm_X85Cs8F7 | max-sixty 5635139 | 2022-05-05T21:47:59Z | 2022-05-05T21:47:59Z | MEMBER | It could be coherent to have:
- I could also imagine raising an error here and having the user coerce the type. That seems less surprising that the current situation. Other languages don't allow floats to be compared for equality at all... |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
32- vs 64-bit coordinates coordinates in where() 1226272301 | |
1119016401 | https://github.com/pydata/xarray/issues/6573#issuecomment-1119016401 | https://api.github.com/repos/pydata/xarray/issues/6573 | IC_kwDOAMm_X85CstXR | benbovy 4160723 | 2022-05-05T20:28:38Z | 2022-05-05T20:31:04Z | MEMBER |
Yes that's right: ```python v32.indexes["x"].intersection(v64.indexes["x"]) Float64Index([0.0, 1.0], dtype='float64', name='x')``` I think the issue is more general than ```python xr.align(c32, c64) (<xarray.DataArray (x: 10)>array([0. , 0.11111111, 0.22222222, 0.33333334, 0.44444445,0.5555556 , 0.6666667 , 0.7777778 , 0.8888889 , 1. ],dtype=float32)Dimensions without coordinates: x,<xarray.DataArray (x: 10)>array([0. , 0.11111111, 0.22222222, 0.33333333, 0.44444444,0.55555556, 0.66666667, 0.77777778, 0.88888889, 1. ])Dimensions without coordinates: x)xr.align(v32.x, v64.x) (<xarray.DataArray 'x' (x: 2)>array([0., 1.], dtype=float32)Coordinates:* x (x) float64 0.0 1.0,<xarray.DataArray 'x' (x: 2)>array([0., 1.])Coordinates:* x (x) float64 0.0 1.0)``` A possible solution would be to handle this special case internally by converting one of the index according to the dtype of the coordinate labels of the other index, similarly to what we are currently doing for the labels that are passed to However, I'm also wondering whether or not we should consider this as a bug. It would make sense to have a behavior that is consistent with ```python v32.x.equals(v64.x) False -- Should we return True here?``` This would be quite weird and wouldn't match the Xarray, Pandas and Numpy behavior below: ```python v32.indexes["x"].equals(v64.indexes["x"]) Falsec64.equals(c32) Falsenp.all(c32.values == c64.values) False``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
32- vs 64-bit coordinates coordinates in where() 1226272301 | |
1118239188 | https://github.com/pydata/xarray/issues/6573#issuecomment-1118239188 | https://api.github.com/repos/pydata/xarray/issues/6573 | IC_kwDOAMm_X85CpvnU | max-sixty 5635139 | 2022-05-05T07:08:46Z | 2022-05-05T07:08:46Z | MEMBER | This does seem very odd. Does anyone have any ideas? As per @forman , changing
...causes the assertion to pass. I'm not sure using floats as indexes is great, but I wouldn't have expected the results to be like this... |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
32- vs 64-bit coordinates coordinates in where() 1226272301 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 4