issue_comments

Table actions

4 rows where issue = 121569683 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • Should Dataset constructor align DataArrays based on coords? · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
350883925 https://github.com/pydata/xarray/issues/674#issuecomment-350883925 https://api.github.com/repos/pydata/xarray/issues/674 MDEyOklzc3VlQ29tbWVudDM1MDg4MzkyNQ== shoyer 1217238 2017-12-11T22:47:13Z 2017-12-11T22:47:26Z MEMBER

Yes. I think we have some existing internal machinery for this in align (see indexes). Indexes that are explicitly provided in coords (e.g., coords={'time': time_values}) should take precedence. Indexes that are incidentally included on another coordinate should not (e.g., coords={'day_of_week': DataArray(values, coords=[('time', time_values)])}).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should Dataset constructor align DataArrays based on coords? 121569683
350839237 https://github.com/pydata/xarray/issues/674#issuecomment-350839237 https://api.github.com/repos/pydata/xarray/issues/674 MDEyOklzc3VlQ29tbWVudDM1MDgzOTIzNw== shoyer 1217238 2017-12-11T19:56:19Z 2017-12-11T19:56:19Z MEMBER

Yes, I think there is a good case that explicitly provided coords should reindex the data. Possibly we should save this for the next major release (0.11) but it should happen. These cases currently result in an error so I'm not worried about backwards compatibility.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should Dataset constructor align DataArrays based on coords? 121569683
163756773 https://github.com/pydata/xarray/issues/674#issuecomment-163756773 https://api.github.com/repos/pydata/xarray/issues/674 MDEyOklzc3VlQ29tbWVudDE2Mzc1Njc3Mw== shoyer 1217238 2015-12-10T21:38:08Z 2015-12-10T21:38:08Z MEMBER

I'm sort of on the fence :). Pandas actually does (1), so there is some precedence for this:

``` In [12]: import pandas as pd

In [13]: df = pd.DataFrame({'x': list('abc')})

In [14]: df Out[14]: x 0 a 1 b 2 c

In [15]: pd.DataFrame(df, index=[1, 2]) Out[15]: x 1 b 2 c ```

That said, I know this has been a point of confusion for new pandas users, and I do like the current property of the Dataset constructor that it never removes data via alignment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should Dataset constructor align DataArrays based on coords? 121569683
163747222 https://github.com/pydata/xarray/issues/674#issuecomment-163747222 https://api.github.com/repos/pydata/xarray/issues/674 MDEyOklzc3VlQ29tbWVudDE2Mzc0NzIyMg== shoyer 1217238 2015-12-10T20:57:48Z 2015-12-10T20:57:48Z MEMBER

Is this desired behavior? I could imagine aligning to coords if they are explicitly supplied, but I don't know the nuances here.

Yes, I think aligning to coords (with an outer join) would probably be a good addition. This was not an intentional omission, just a scenario I did not anticipate. I don't see any obvious reason reason why coords should be treated differently than data_vars as far as data alignment in the Dataset constructor goes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Should Dataset constructor align DataArrays based on coords? 121569683

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);