issue_comments

Table actions

6 rows where issue = 1200309334 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Support **kwargs form in `.chunk()` · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1095932543 https://github.com/pydata/xarray/pull/6471#issuecomment-1095932543 https://api.github.com/repos/pydata/xarray/issues/6471 IC_kwDOAMm_X85BUpp_ TomNicholas 35968931 2022-04-12T03:34:48Z 2022-04-12T03:34:48Z MEMBER

Sorry @djhoese for having an itchy merge finger :sweat_smile: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support **kwargs form in `.chunk()` 1200309334
1095790236 https://github.com/pydata/xarray/pull/6471#issuecomment-1095790236 https://api.github.com/repos/pydata/xarray/issues/6471 IC_kwDOAMm_X85BUG6c djhoese 1828519 2022-04-12T01:38:12Z 2022-04-12T01:38:12Z CONTRIBUTOR

Thanks for the fix. It is always risking merging before all CI is finished, especially when code is modified.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support **kwargs form in `.chunk()` 1200309334
1095570154 https://github.com/pydata/xarray/pull/6471#issuecomment-1095570154 https://api.github.com/repos/pydata/xarray/issues/6471 IC_kwDOAMm_X85BTRLq max-sixty 5635139 2022-04-11T21:11:51Z 2022-04-11T21:11:51Z MEMBER

I only made suggestions for a subset of the Number entries. Probably we should have waited at least for the pre-commit ci to pass.

Something I've done on my other projects is enable "Auto-merging", so you can hit the button and it'll merge when tests pass. Currently GH requires enumerating every check you want to require passing, which then needs to be adjusted every time the test specs change — there's no button for "all". But maybe we should do that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support **kwargs form in `.chunk()` 1200309334
1095564967 https://github.com/pydata/xarray/pull/6471#issuecomment-1095564967 https://api.github.com/repos/pydata/xarray/issues/6471 IC_kwDOAMm_X85BTP6n max-sixty 5635139 2022-04-11T21:05:46Z 2022-04-11T21:05:46Z MEMBER

Apologies @djhoese ! Fixing in https://github.com/pydata/xarray/pull/6474.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support **kwargs form in `.chunk()` 1200309334
1095537116 https://github.com/pydata/xarray/pull/6471#issuecomment-1095537116 https://api.github.com/repos/pydata/xarray/issues/6471 IC_kwDOAMm_X85BTJHc djhoese 1828519 2022-04-11T20:31:24Z 2022-04-11T20:34:34Z CONTRIBUTOR

This uses the Number object but never imports it and is causing CI failures on my unstable dependency environment:

https://github.com/pydata/xarray/blob/ec13944bbd4022614491b6ec479ff2618da14ba8/xarray/core/dataarray.py#L1156

Not sure how the tests didn't hit this or any of the linting checks.

Edit: Ah I see, the tests all failed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support **kwargs form in `.chunk()` 1200309334
1095482545 https://github.com/pydata/xarray/pull/6471#issuecomment-1095482545 https://api.github.com/repos/pydata/xarray/issues/6471 IC_kwDOAMm_X85BS7yx TomNicholas 35968931 2022-04-11T19:36:54Z 2022-04-11T19:36:54Z MEMBER

Thanks for the rapid review @max-sixty !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Support **kwargs form in `.chunk()` 1200309334

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);