issue_comments

Table actions

7 rows where issue = 1199127752 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • allow other and drop arguments in where (gh#6466) · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1096953860 https://github.com/pydata/xarray/pull/6467#issuecomment-1096953860 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BYjAE delgadom 3698640 2022-04-12T16:39:53Z 2022-04-12T16:39:53Z CONTRIBUTOR

oof - debugging CI build process is no fun. good luck, and thanks @max-sixty !!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752
1096882307 https://github.com/pydata/xarray/pull/6467#issuecomment-1096882307 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BYRiD max-sixty 5635139 2022-04-12T15:33:14Z 2022-04-12T15:33:14Z MEMBER

Thank you @delgadom !!

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752
1096882020 https://github.com/pydata/xarray/pull/6467#issuecomment-1096882020 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BYRdk max-sixty 5635139 2022-04-12T15:32:59Z 2022-04-12T15:32:59Z MEMBER

I'm merging this and fixing the whatsnew on L39 in a different PR.

Not a great CI run the past few days!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752
1094412333 https://github.com/pydata/xarray/pull/6467#issuecomment-1094412333 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BO2gt max-sixty 5635139 2022-04-10T23:47:47Z 2022-04-10T23:47:47Z MEMBER

hmm. readthedocs failed because of concurrency limits (my bad) but seems to have failed to automatically retry. can someone give it a nudge?

Hmmm, I haven't seen this before, maybe it's a change, maybe it's a fluke. I hit the button, let's see if it resolves.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752
1094409424 https://github.com/pydata/xarray/pull/6467#issuecomment-1094409424 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BO1zQ delgadom 3698640 2022-04-10T23:29:38Z 2022-04-10T23:29:38Z CONTRIBUTOR

hmm. readthedocs failed because of concurrency limits (my bad) but seems to have failed to automatically retry. can someone give it a nudge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752
1094342045 https://github.com/pydata/xarray/pull/6467#issuecomment-1094342045 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BOlWd delgadom 3698640 2022-04-10T18:26:32Z 2022-04-10T18:26:32Z CONTRIBUTOR

thanks @max-sixty! I was mostly trying to be overly-cautious because the ValueError was so clearly raised intentionally, and I can't figure out why it was necessary. But maybe it was just left over from a time when providing both arguments really would have caused a problem, and it's no longer the case.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752
1094340795 https://github.com/pydata/xarray/pull/6467#issuecomment-1094340795 https://api.github.com/repos/pydata/xarray/issues/6467 IC_kwDOAMm_X85BOlC7 max-sixty 5635139 2022-04-10T18:19:25Z 2022-04-10T18:19:25Z MEMBER

Thanks @delgadom !

I think this is a good idea! Any thoughts?

Note @delgadom 's thoughtful comment in the issue:

I haven't yet investigated what would happen with chunked, sparse, or other complex arrays, or if it's compatible with trees and other things on the roadmap. It's possible this breaks things I'm not imagining. Currently, where(cond, other) and where(cond, drop=True) are well-tested, flexible operations, and I don't see why allowing their union would break anything, but I'll wait to hear from the experts on that front!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow other and drop arguments in where (gh#6466) 1199127752

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);