issue_comments

Table actions

3 rows where issue = 1198668507 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Provide protocols for creating structural subtypes of DataArray/Dataset · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1312784861 https://github.com/pydata/xarray/issues/6462#issuecomment-1312784861 https://api.github.com/repos/pydata/xarray/issues/6462 IC_kwDOAMm_X85OP4Hd chrissype 33806291 2022-11-13T17:48:03Z 2022-11-13T17:48:03Z NONE

I'm considering leveraging the power of xarray to greatly simplify a codebase that has its own types that essentially implement a very poor version of xarray's functionality.

However to be able to justify integrating it into a large codebase with multiple developers, type hints for linting, autocomplete, and (possibly) static type checking are completely non-optional.

Adding this functionality to xarray would make it a shoo-in, and I believe the approach suggested by @rsokl is probably the best.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide protocols for creating structural subtypes of DataArray/Dataset 1198668507
1114048958 https://github.com/pydata/xarray/issues/6462#issuecomment-1114048958 https://api.github.com/repos/pydata/xarray/issues/6462 IC_kwDOAMm_X85CZwm- max-sixty 5635139 2022-04-30T20:25:59Z 2022-04-30T20:25:59Z MEMBER

Sorry not to respond for a few days. I think this is a good idea if there's demand for it. It would require a small amount of maintenance as the dataset implementation changes, but very manageable.

FWIW I frequently find myself having a ds being passing around in an app, and it would be awesome to be able to define and statically check the data variables.

(We've discussed also being able to define and statically check the dimensions, that's a separate issue though)

 
{
    "total_count": 7,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 7,
    "eyes": 0
}
   Provide protocols for creating structural subtypes of DataArray/Dataset 1198668507
1114006429 https://github.com/pydata/xarray/issues/6462#issuecomment-1114006429 https://api.github.com/repos/pydata/xarray/issues/6462 IC_kwDOAMm_X85CZmOd paiforsyth 32946545 2022-04-30T15:27:22Z 2022-04-30T15:37:42Z NONE

I can't comment on the implementation, but this is certainly a feature I would appreciate. I have been using xarray a lot recently, and have found myself frequently writing functions that map Datasets to Datasets. The ability to encode the expected schemas in type annotations would be very valuable for correctness and documentation. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Provide protocols for creating structural subtypes of DataArray/Dataset 1198668507

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);