issue_comments

Table actions

5 rows where issue = 1174427142 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • `Dataset.to_zarr` compute=False should allow access to awaitable · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1073389475 https://github.com/pydata/xarray/issues/6383#issuecomment-1073389475 https://api.github.com/repos/pydata/xarray/issues/6383 IC_kwDOAMm_X84_-p-j shaunc 193170 2022-03-21T00:47:45Z 2022-03-21T00:47:45Z NONE

You can return a awaitable explicitly without declaring async. I'm not sure what the best style is -- if there is no await then asyncio will issue a warning in debug mode. Perhaps you can mark it ... Alternately, you could pass in an event loop to computed=, which would trigger the task being added with create_task() (as well as being returned?)

As for a contribution ... I'm already hacking on something but it isn't pretty. Will need to think more about how to do it the right way.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr` compute=False should allow access to awaitable 1174427142
1073316705 https://github.com/pydata/xarray/issues/6383#issuecomment-1073316705 https://api.github.com/repos/pydata/xarray/issues/6383 IC_kwDOAMm_X84_-YNh max-sixty 5635139 2022-03-20T19:27:46Z 2022-03-20T19:27:46Z MEMBER

That makes sense for the fsspec part, but IIUC we'd also have to make the rest of to_zarr async too?

If it could be made to work without a backward-incompatible change , I think we'd be open to the contribution though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr` compute=False should allow access to awaitable 1174427142
1073313461 https://github.com/pydata/xarray/issues/6383#issuecomment-1073313461 https://api.github.com/repos/pydata/xarray/issues/6383 IC_kwDOAMm_X84_-Xa1 shaunc 193170 2022-03-20T19:07:56Z 2022-03-20T19:07:56Z NONE

to_zarr could return a task if compute=False even without being async. zarr depends on fsspec depends of s3fs which is async. I think you can get an awaitable from fsspec. I'm not sure about zarr, but looks like you can pass your own store -- which may be the way to do it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr` compute=False should allow access to awaitable 1174427142
1073312007 https://github.com/pydata/xarray/issues/6383#issuecomment-1073312007 https://api.github.com/repos/pydata/xarray/issues/6383 IC_kwDOAMm_X84_-XEH max-sixty 5635139 2022-03-20T19:00:34Z 2022-03-20T19:00:34Z MEMBER

I think this would require to_zarr being async — is that correct? If so, that's not unfortunately not possible at the moment, and IIUC would require quite large incompatible changes to make work...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr` compute=False should allow access to awaitable 1174427142
1073159748 https://github.com/pydata/xarray/issues/6383#issuecomment-1073159748 https://api.github.com/repos/pydata/xarray/issues/6383 IC_kwDOAMm_X84_9x5E shaunc 193170 2022-03-20T03:41:57Z 2022-03-20T03:42:14Z NONE

Hmm... probably I should be filing a feature request for this rather than a bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `Dataset.to_zarr` compute=False should allow access to awaitable 1174427142

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);