issue_comments

Table actions

15 rows where issue = 116256319 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • docs consistent with Dataset constructor taking variables · 15 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
161747978 https://github.com/pydata/xarray/pull/654#issuecomment-161747978 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE2MTc0Nzk3OA== shoyer 1217238 2015-12-03T19:00:54Z 2015-12-03T19:00:54Z MEMBER

thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
161706063 https://github.com/pydata/xarray/pull/654#issuecomment-161706063 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE2MTcwNjA2Mw== max-sixty 5635139 2015-12-03T16:29:22Z 2015-12-03T16:29:22Z MEMBER

@shoyer I think this is ready now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
159047743 https://github.com/pydata/xarray/pull/654#issuecomment-159047743 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1OTA0Nzc0Mw== max-sixty 5635139 2015-11-23T20:03:41Z 2015-11-23T20:03:41Z MEMBER

Apologies! Will fix

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
159045769 https://github.com/pydata/xarray/pull/654#issuecomment-159045769 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1OTA0NTc2OQ== shoyer 1217238 2015-11-23T19:57:37Z 2015-11-23T19:57:37Z MEMBER

Sorry still a few places where the terminology was mixed up. We aren't renaming the DataArray argument here :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
158609819 https://github.com/pydata/xarray/pull/654#issuecomment-158609819 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1ODYwOTgxOQ== max-sixty 5635139 2015-11-21T07:48:45Z 2015-11-21T07:48:45Z MEMBER

@shoyer updated & green

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
158236320 https://github.com/pydata/xarray/pull/654#issuecomment-158236320 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1ODIzNjMyMA== shoyer 1217238 2015-11-19T23:47:45Z 2015-11-19T23:47:45Z MEMBER

Thanks for the reminder -- just a few minor corrections

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
158232695 https://github.com/pydata/xarray/pull/654#issuecomment-158232695 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1ODIzMjY5NQ== max-sixty 5635139 2015-11-19T23:26:39Z 2015-11-19T23:26:39Z MEMBER

@shoyer let me know any feedback / changes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
157543297 https://github.com/pydata/xarray/pull/654#issuecomment-157543297 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NzU0MzI5Nw== max-sixty 5635139 2015-11-17T23:25:01Z 2015-11-17T23:25:01Z MEMBER

@shoyer updated

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
157193241 https://github.com/pydata/xarray/pull/654#issuecomment-157193241 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NzE5MzI0MQ== max-sixty 5635139 2015-11-16T22:35:51Z 2015-11-16T22:35:51Z MEMBER

@shoyer How's that? I think there some more stuff to do on the docs, but that's a stable upgrade for now? Very open to feedback, docs are definitely not my strong point.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
157136187 https://github.com/pydata/xarray/pull/654#issuecomment-157136187 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NzEzNjE4Nw== shoyer 1217238 2015-11-16T19:00:22Z 2015-11-16T19:00:22Z MEMBER

Yes, this is great -- thank you!

I do think it would be a good idea to rename that first Dataset parameter to data_vars. That would certainly be more consistent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
157103064 https://github.com/pydata/xarray/pull/654#issuecomment-157103064 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NzEwMzA2NA== max-sixty 5635139 2015-11-16T17:12:10Z 2015-11-16T17:12:10Z MEMBER

@shoyer made some changes to the DataArray construction docs - let me know if those are in the right direction. I imagine there's still some way to go there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
156015350 https://github.com/pydata/xarray/pull/654#issuecomment-156015350 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NjAxNTM1MA== max-sixty 5635139 2015-11-12T06:41:38Z 2015-11-12T06:45:24Z MEMBER

Happy to make that change as part of this - LMK. Also worth considering whether mirroring the DataArray arguments (data=) would make it more consistent (different types though, so maybe not)

If we make the change, I'd keep the old one around as a deprecated kwarg 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
156014938 https://github.com/pydata/xarray/pull/654#issuecomment-156014938 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NjAxNDkzOA== shoyer 1217238 2015-11-12T06:39:38Z 2015-11-12T06:39:38Z MEMBER

Hmm. Maybe it would be a good idea to rename variables to data_vars in the constructor. The argument name is really a relic of the old xray data model which didn't distinguish between data_vars and coords.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
156014577 https://github.com/pydata/xarray/pull/654#issuecomment-156014577 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NjAxNDU3Nw== max-sixty 5635139 2015-11-12T06:35:51Z 2015-11-12T06:38:36Z MEMBER

Ah OK, I'll make that change. Looks like there's enough going on there that having the args in the constructor & the attributes on the object mirrored would be tough...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319
156005389 https://github.com/pydata/xarray/pull/654#issuecomment-156005389 https://api.github.com/repos/pydata/xarray/issues/654 MDEyOklzc3VlQ29tbWVudDE1NjAwNTM4OQ== shoyer 1217238 2015-11-12T05:34:20Z 2015-11-12T05:34:20Z MEMBER

We should document .variables more clearly. It is indeed the fundamental property we use under the covers, but variables in .variables are stored as xray.Variable objects which is a low level API -- hence why we point people to .data_vars and .coords instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   docs consistent with Dataset constructor taking variables 116256319

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);