issue_comments

Table actions

5 rows where issue = 1160073438 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1093106370 https://github.com/pydata/xarray/pull/6334#issuecomment-1093106370 https://api.github.com/repos/pydata/xarray/issues/6334 IC_kwDOAMm_X85BJ3rC dcherian 2448579 2022-04-08T17:18:44Z 2022-04-08T17:18:44Z MEMBER

It seemed a little cleaner, but you're right, it's a minor comment. Let's merge. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers 1160073438
1093061133 https://github.com/pydata/xarray/pull/6334#issuecomment-1093061133 https://api.github.com/repos/pydata/xarray/issues/6334 IC_kwDOAMm_X85BJsoN stanwest 38358698 2022-04-08T16:23:01Z 2022-04-08T16:23:01Z CONTRIBUTOR

For my understanding and curiosity, what are the perceived benefits of a separate function to warn about splitting the preferred chunks? It seemed better to me to avoid the overhead of the function call and the unnecessary internal interface, particularly considering that the function was private, had only one caller, and was so closely related to its caller.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers 1160073438
1091856602 https://github.com/pydata/xarray/pull/6334#issuecomment-1091856602 https://api.github.com/repos/pydata/xarray/issues/6334 IC_kwDOAMm_X85BFGja dcherian 2448579 2022-04-07T15:07:10Z 2022-04-07T15:07:10Z MEMBER

Thanks for the review @aurghs. @stanwest would you mind bringing back check_chunks_compatbility please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers 1160073438
1091797026 https://github.com/pydata/xarray/pull/6334#issuecomment-1091797026 https://api.github.com/repos/pydata/xarray/issues/6334 IC_kwDOAMm_X85BE4Ai stanwest 38358698 2022-04-07T14:15:13Z 2022-04-07T14:15:13Z CONTRIBUTOR

Thank you for this fix! It looks good to me.

Thanks for the review and approval. Is this PR ready to trade the "needs review" label for the "plan to merge" label?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers 1160073438
1091315261 https://github.com/pydata/xarray/pull/6334#issuecomment-1091315261 https://api.github.com/repos/pydata/xarray/issues/6334 IC_kwDOAMm_X85BDCY9 aurghs 35919497 2022-04-07T08:33:43Z 2022-04-07T08:37:33Z COLLABORATOR

Thank you for this fix! It looks good to me. I would prefer a separate function for the check, but that's fine too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   In backends, support expressing a dimension's preferred chunk sizes as a tuple of integers 1160073438

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);