home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where issue = 1158378382 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

  • jhamman 2
  • klindsay28 2
  • rabernat 1
  • shoyer 1

author_association 2

  • MEMBER 4
  • NONE 2

issue 1

  • propagation of `encoding` · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1497455189 https://github.com/pydata/xarray/issues/6323#issuecomment-1497455189 https://api.github.com/repos/pydata/xarray/issues/6323 IC_kwDOAMm_X85ZQVpV klindsay28 15570875 2023-04-05T13:06:12Z 2023-04-05T13:06:12Z NONE

In a future where encoding has been removed from Xarray's data model entirely, would open_dataset_with_encoding, or whatever name gets settled on, still exist? It's not clear to me if removal from the data model means just removing it from Xarray's data structures, or if it also means removing it from Xarray's APIs.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  propagation of `encoding` 1158378382
1496912849 https://github.com/pydata/xarray/issues/6323#issuecomment-1496912849 https://api.github.com/repos/pydata/xarray/issues/6323 IC_kwDOAMm_X85ZORPR shoyer 1217238 2023-04-05T04:49:34Z 2023-04-05T04:49:34Z MEMBER

In the hypothetical invocation open_dataset(..., return_encoding=True), do you envision the returned encoding as being a separate returned object, or would it still be an attribute on the Dataset object?

My expectation was that this would be a separate object, e.g., dataset, encoding = xarray.open_dataset(..., return_encoding=True), where encoding is a dict providing the encoding on each variable, and which could be passed as the encoding argument into to_netcdf(). That said, I can see how keeping encoding as variable attributes could also be convenient.

"disable all encoding propagation by discarding encoding attributes once a Dataset has been modified" would be an intermediate step, on the route to removing encoding from Xarray's data model entirely entirely.

(As a side note, I would probably spell this as open_dataset_with_encoding rather than having a function with a variable return signature.)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  propagation of `encoding` 1158378382
1496845498 https://github.com/pydata/xarray/issues/6323#issuecomment-1496845498 https://api.github.com/repos/pydata/xarray/issues/6323 IC_kwDOAMm_X85ZOAy6 klindsay28 15570875 2023-04-05T02:46:02Z 2023-04-05T02:46:02Z NONE

In the hypothetical invocation open_dataset(..., return_encoding=True), do you envision the returned encoding as being a separate returned object, or would it still be an attribute on the Dataset object? I'm guessing the latter, because the subsequent statement 'disable all encoding propagation by discarding encoding attributes once a Dataset has been modified' doesn't make much sense to me for the former. If so, after encoding attributes are discarded, would there still be an encoding attribute on the Dataset object that the user could reset to the values prior to the Dataset modification? This would enable the user to propagate encoding values through their workflow.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  propagation of `encoding` 1158378382
1492139481 https://github.com/pydata/xarray/issues/6323#issuecomment-1492139481 https://api.github.com/repos/pydata/xarray/issues/6323 IC_kwDOAMm_X85Y8D3Z rabernat 1197350 2023-03-31T15:31:55Z 2023-03-31T15:31:55Z MEMBER

We should also consider a configuration option to automatically drop encoding.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  propagation of `encoding` 1158378382
1492098719 https://github.com/pydata/xarray/issues/6323#issuecomment-1492098719 https://api.github.com/repos/pydata/xarray/issues/6323 IC_kwDOAMm_X85Y756f jhamman 2443309 2023-03-31T15:14:59Z 2023-03-31T15:14:59Z MEMBER

This issue was discussed at this week's dev meeting. I will summarize what we discussed:

  1. General agreement that propagating encoding through arbitrary operations (e.g. slice, chunk, computation) leads to inconsistent states that are hard to protect against. This often leads to problems when serializing datasets in our backends.
  2. The primary benefit of keeping encoding on Xarray objects is the ability to exactly roundtrip datasets. However, this benefit is less obvious after a dataset has been modified.
  3. We currently have two APIs for setting encoding (e.g. to_netcdf(..., encoding={...}) and ds.encoding = {...}). We should change this by deprecating setting encoding on Xarray objects using the .encoding property.
  4. We can move towards providing utilities that expose a dataset's source encoding (e.g. open_dataset(..., return_encoding=True).

Specific action items that can happen now: - [x] add reset_encoding to Dataset/DatAarray api (https://github.com/pydata/xarray/issues/7686) - [ ] add a DeprecationWarning to the @property.setter for encoding on Dataset/DatAarray/Variable - [ ] document the change in callout in the Xarray user guide.

Longer term action items: - [ ] add option to backend readers to keep / discard interpreted encoding attributes - [ ] disable all encoding propagation by discarding encoding attributes once a Dataset has been modified.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  propagation of `encoding` 1158378382
1485792995 https://github.com/pydata/xarray/issues/6323#issuecomment-1485792995 https://api.github.com/repos/pydata/xarray/issues/6323 IC_kwDOAMm_X85Yj2bj jhamman 2443309 2023-03-27T20:06:07Z 2023-03-27T20:06:24Z MEMBER

See also https://github.com/pydata/xarray/issues/7686. The ideas presented here are also great!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  propagation of `encoding` 1158378382

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 399.375ms · About: xarray-datasette
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows