issue_comments

Table actions

4 rows where issue = 115805419 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • jhamman · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
162061150 https://github.com/pydata/xarray/pull/648#issuecomment-162061150 https://api.github.com/repos/pydata/xarray/issues/648 MDEyOklzc3VlQ29tbWVudDE2MjA2MTE1MA== jhamman 2443309 2015-12-04T19:33:18Z 2015-12-04T19:33:18Z MEMBER

lgtm, go ahead and merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rework DataArray internals 115805419
161468195 https://github.com/pydata/xarray/pull/648#issuecomment-161468195 https://api.github.com/repos/pydata/xarray/issues/648 MDEyOklzc3VlQ29tbWVudDE2MTQ2ODE5NQ== jhamman 2443309 2015-12-02T23:39:53Z 2015-12-02T23:39:53Z MEMBER

@shoyer - I don't have any more inline comments. There is one failing test and there are merge conflicts, once those are addressed, I'll take one more brief look. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rework DataArray internals 115805419
155566138 https://github.com/pydata/xarray/pull/648#issuecomment-155566138 https://api.github.com/repos/pydata/xarray/issues/648 MDEyOklzc3VlQ29tbWVudDE1NTU2NjEzOA== jhamman 2443309 2015-11-10T21:07:42Z 2015-11-10T21:07:42Z MEMBER

@shoyer - do you have a feel for how difficult it would be to go the variable/coords route?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rework DataArray internals 115805419
155530747 https://github.com/pydata/xarray/pull/648#issuecomment-155530747 https://api.github.com/repos/pydata/xarray/issues/648 MDEyOklzc3VlQ29tbWVudDE1NTUzMDc0Nw== jhamman 2443309 2015-11-10T18:56:07Z 2015-11-10T18:56:07Z MEMBER

@shoyer - I read this mainly trying to get a better idea of the internal DataArray data model. The code itself looks great. My main two comments on the refactor are: 1. The use of the _ThisArray singleton seems a bit clunky to me. This is my first time interacting with this approach so maybe it is the best way, but I don't know much about it. 2. This all seems to be complicated by the DataArrays's use of the Dataset internally to store coordinates. Not for this PR, but I wonder if there is a way to clear up the lines between the two objects.

All in all, impressive work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rework DataArray internals 115805419

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);