issue_comments

Table actions

5 rows where issue = 1138440632 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Allow to parse more backend kwargs to pydap backend · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1041499267 https://github.com/pydata/xarray/pull/6276#issuecomment-1041499267 https://api.github.com/repos/pydata/xarray/issues/6276 IC_kwDOAMm_X84-FASD jgliss 12813228 2022-02-16T13:36:28Z 2022-02-16T13:36:28Z CONTRIBUTOR

I would prefer to avoid using **kwargs, the explicit list of parameters would make the code more readable. But I think it's fine that way too :)

Thanks, rethinking it, I agree that it is better to set the allowed arguments explicitly. I updated it accordingly and hope this looks fine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow to parse more backend kwargs to pydap backend 1138440632
1041249397 https://github.com/pydata/xarray/pull/6276#issuecomment-1041249397 https://api.github.com/repos/pydata/xarray/issues/6276 IC_kwDOAMm_X84-EDR1 aurghs 35919497 2022-02-16T08:46:05Z 2022-02-16T08:46:24Z COLLABORATOR

I would prefer to avoid using **kwargs, the explicit list of parameters would make the code more readable. But I think it's fine that way too :)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow to parse more backend kwargs to pydap backend 1138440632
1040590938 https://github.com/pydata/xarray/pull/6276#issuecomment-1040590938 https://api.github.com/repos/pydata/xarray/issues/6276 IC_kwDOAMm_X84-Biha jgliss 12813228 2022-02-15T17:49:52Z 2022-02-15T17:49:52Z CONTRIBUTOR

Looks like you need to define a open_dataset_parameters class variable if you want to pass on kwargs. I would prefer this but I don't have much experience with the backends, so others opinions may differ @aurghs @alexamici

See for example:

https://github.com/pydata/xarray/blob/8c5c230881d616af32c5a42cca261eb11fce3916/xarray/backends/pseudonetcdf_.py#L107-L111

If you want to keep the named arguments I would probably avoid inspect and just pass kwargs that are not None:

```python kwargs = {"a": 5, "b": None}

only pass on kwargs that are not None -> pydap has some defaults that are not None

kwargs = {key: value for key, value in kwargs.items() if value is not None} ```

@mathause thanks for your comments, I implemented your suggestion using open_dataset_parameters, hope this is sufficient. The code is covered by existing tests (using formerly keyword arg session), but let me know if you think I should add more tests, for the additional arguments. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow to parse more backend kwargs to pydap backend 1138440632
1040230765 https://github.com/pydata/xarray/pull/6276#issuecomment-1040230765 https://api.github.com/repos/pydata/xarray/issues/6276 IC_kwDOAMm_X84-AKlt mathause 10194086 2022-02-15T12:45:53Z 2022-02-15T12:45:53Z MEMBER

Looks like you need to define a open_dataset_parameters class variable if you want to pass on kwargs. I would prefer this but I don't have much experience with the backends, so others opinions may differ @aurghs @alexamici

See for example:

https://github.com/pydata/xarray/blob/8c5c230881d616af32c5a42cca261eb11fce3916/xarray/backends/pseudonetcdf_.py#L107-L111

If you want to keep the named arguments I would probably avoid inspect and just pass kwargs that are not None:

```python kwargs = {"a": 5, "b": None}

only pass on kwargs that are not None -> pydap has some defaults that are not None

kwargs = {key: value for key, value in kwargs.items() if value is not None} ```

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow to parse more backend kwargs to pydap backend 1138440632
1040074548 https://github.com/pydata/xarray/pull/6276#issuecomment-1040074548 https://api.github.com/repos/pydata/xarray/issues/6276 IC_kwDOAMm_X849_kc0 jgliss 12813228 2022-02-15T09:57:18Z 2022-02-15T09:57:18Z CONTRIBUTOR

I am not sure if the proposed changes are in compliance with the plugin restrictions related to parsing of **kwargs, etc. which is likely for very good reason. So, we could also be more explicit regarding how to deal with pydap's defaults, directly in PydapBackendEntrypoint, and set the defaults directly (which could lead to unnoticed deviations from pydap's defaults in upcoming releases).

I appreciate comments and suggestions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow to parse more backend kwargs to pydap backend 1138440632

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);