issue_comments

Table actions

7 rows where issue = 1132894350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Adding CDL Parser/`open_cdl`? · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1039346079 https://github.com/pydata/xarray/issues/6269#issuecomment-1039346079 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X8498ymf nbren12 1386642 2022-02-14T17:18:38Z 2022-02-14T17:18:38Z CONTRIBUTOR

@jhamman We have a similar schema package https://github.com/ai2cm/fv3net/tree/master/external/synth, cool to see you confronting the same challenges and advertising your solutions more broadly. One problem we had is that our schema objects ended up being quite verbose: https://github.com/ai2cm/fv3net/blob/master/external/loaders/tests/test__batch/one_step_zarr_schema.json. CDL is a lot more concise.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350
1036719578 https://github.com/pydata/xarray/issues/6269#issuecomment-1036719578 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X849yxXa jhamman 2443309 2022-02-11T22:58:12Z 2022-02-11T22:58:12Z MEMBER

To be fair, ds.info is not 100% CDL, but it's darn close.

I think making ds.info CDL compliant would be a great feature addition.

Describe alternatives you've considered

Some kind of schema object that can be used to validate or generate an xarray Dataset, but does not contain any data.

You may be interested in xarray-schema then. We're actively working on / using this project and would be more than happy to think about how a cdl-like schema fits in there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350
1036516070 https://github.com/pydata/xarray/issues/6269#issuecomment-1036516070 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X849x_rm nbren12 1386642 2022-02-11T18:52:12Z 2022-02-11T18:52:12Z CONTRIBUTOR

To be fair, ds.info is not 100% CDL, but it's darn close.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350
1036514917 https://github.com/pydata/xarray/issues/6269#issuecomment-1036514917 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X849x_Zl kmuehlbauer 5821660 2022-02-11T18:50:34Z 2022-02-11T18:50:34Z MEMBER
  1. creates CDL using ds.info().

Great, this somehow went past me. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350
1036505143 https://github.com/pydata/xarray/issues/6269#issuecomment-1036505143 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X849x9A3 dcherian 2448579 2022-02-11T18:37:25Z 2022-02-11T18:37:25Z MEMBER

@nbren12 See https://docs.xarray.dev/en/stable/internals/how-to-add-new-backend.html for adding a new backend. That way we could have

xr.open_dataset('schema.cdl', engine="cdl")

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350
1036502148 https://github.com/pydata/xarray/issues/6269#issuecomment-1036502148 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X849x8SE nbren12 1386642 2022-02-11T18:33:42Z 2022-02-11T18:33:49Z CONTRIBUTOR

Aren't there xarray extension packages around where this would fit into?

I'm not sure. Any suggestions? Just wondering if xarray has left the door open to this kind of contribution since it 1. already supports other i/o backends 2. creates CDL using ds.info().

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350
1036458613 https://github.com/pydata/xarray/issues/6269#issuecomment-1036458613 https://api.github.com/repos/pydata/xarray/issues/6269 IC_kwDOAMm_X849xxp1 kmuehlbauer 5821660 2022-02-11T17:45:47Z 2022-02-11T17:46:04Z MEMBER

@nbren12 The other way round would be useful too. Aren't there xarray extension packages around where this would fit into?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding CDL Parser/`open_cdl`? 1132894350

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);