issue_comments

Table actions

4 rows where issue = 1128485610 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • removed check for last dask chunk size in to_zarr · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1033803014 https://github.com/pydata/xarray/pull/6258#issuecomment-1033803014 https://api.github.com/repos/pydata/xarray/issues/6258 IC_kwDOAMm_X849npUG d70-t 6574622 2022-02-09T14:12:21Z 2022-02-09T14:12:21Z CONTRIBUTOR

Indeed, those variable names have been quite unfortunate! I've changed them to goodenc. Thanks again for the review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   removed check for last dask chunk size in to_zarr 1128485610
1033782892 https://github.com/pydata/xarray/pull/6258#issuecomment-1033782892 https://api.github.com/repos/pydata/xarray/issues/6258 IC_kwDOAMm_X849nkZs rabernat 1197350 2022-02-09T13:51:55Z 2022-02-09T13:51:55Z MEMBER

came to the conclusion that the previously existing tests had been overly restrictive

Sounds very likely!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   removed check for last dask chunk size in to_zarr 1128485610
1033781323 https://github.com/pydata/xarray/pull/6258#issuecomment-1033781323 https://api.github.com/repos/pydata/xarray/issues/6258 IC_kwDOAMm_X849nkBL d70-t 6574622 2022-02-09T13:50:13Z 2022-02-09T13:50:13Z CONTRIBUTOR

Thanks Ryan for having a look into this.

Accidentally I didn't run enough of the tests locally before submitting the PR. I've now checked the failing tests and came to the conclusion that the previously existing tests had been overly restrictive and rewrote them to reflect more closely what I believe that we actually want.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   removed check for last dask chunk size in to_zarr 1128485610
1033757210 https://github.com/pydata/xarray/pull/6258#issuecomment-1033757210 https://api.github.com/repos/pydata/xarray/issues/6258 IC_kwDOAMm_X849neIa rabernat 1197350 2022-02-09T13:23:23Z 2022-02-09T13:23:23Z MEMBER

Thanks for working on this Tobias! Yes I implemented much of the Dask / Zarr interface and would be happy to review when you're ready.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   removed check for last dask chunk size in to_zarr 1128485610

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);