issue_comments

Great news! Thank you Dave!

On Wed, Nov 4, 2015 at 10:27 AM, Dave Brown notifications@github.com wrote:

The PyNIO license has been rewritten as a standard 3-clause BSD license. Hopefully this satisfies all concerns.

http://www.pyngl.ucar.edu/Licenses/PyNIO_source_license.shtml

We will put it on the github page when it is made public.

On Thu, Oct 29, 2015 at 2:40 PM, Stephan Hoyer notifications@github.com wrote:

I agree that the license seems complaint with OSI guidelines, but nonetheless it isn't an OSI approved license. These FAQ entries seem relevant: http://opensource.org/faq#approved-licenses-only

— Reply to this email directly or view it on GitHub https://github.com/xray/xray/pull/636#issuecomment-152312224.

— Reply to this email directly or view it on GitHub https://github.com/xray/xray/pull/636#issuecomment-153820521.

I agree that the license seems complaint with OSI guidelines, but nonetheless it isn't an OSI approved license. These FAQ entries seem relevant: http://opensource.org/faq#approved-licenses-only

Actually I looked a little more carefully and the PyNIO license is not quite BSD -- the disclaimer of liability at the bottom is different. It looks like it's actually taken from the MIT license, with a few words copied from BSD: "INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES".

In any case, both MIT and BSD are OSI approved with similar restrictions, so I'm sure this license is also fine. I have not idea if this license is original to PyNIO or not, but it would be nice to be able to say that you use a standard license -- it makes this stuff a bit simpler.

Aside from the notice at the top "PLEASE READ THIS SOFTWARE LICENSE CAREFULLY" the license is ~~direct~~ almost exact copy of 3 clause BSD. It would be great to get this in the readme (once you're on github) to make this entirely clear.

The link for the license to GRIBX no longer works on the ECMWF website. But some googling turns up source files with the Apache 2.0 license attached, so I think we're in the clear (Apache 2.0 is BSD compatible). In any case, it should be in the PyNIO source code. For easier reference, it would be better to copy in the text of any referenced licenses in the PyNIO license itself, though.

@david-ian-brown What license are you using for PyNIO? It looks like a standard 3 clause BSD? This would be helpful information to highlight on the new GitHub site -- I could only finding it by searching google, not by navigating on the website.

Thanks again @david-ian-brown for your help with this. We've already been finding being able to use xray with pynio to be quite useful -- being able to read grib files is a killer feature.

Good call. I added a small section to Serialization & IO:

OK, great -- the units tests are now passing on travis, using numpy 1.9. There's no particularly good reason why we aren't testing against numpy 1.10 -- it just happens that I arbitrarily decided to test cdat-lite with the same build, and it only supports numpy 1.9 or older.

If there are no objections I'll be merging this shortly.

@david-ian-brown This is working for me on OS X, but I'm getting an error when I attempt to import your conda build of pynio on Linux:

```

import Nio RuntimeError: module compiled against API version a but this version of numpy is 9 Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/export/data/envs/test_env/lib/python2.7/site-packages/PyNIO/Nio.py", line 83, in <module> from nio import * ImportError: numpy.core.multiarray failed to import ```

Can you reproduce this? I think this is an ABI compatibility issue (ugh!) related to building against one version of numpy but installing another. To that end, it's probably worth trying specifying specific numpy requirements.

There were a few other issues that came up here that I'll note in specific comments on the code.