issue_comments

Table actions

5 rows where issue = 1120583442 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • [PERFORMANCE]: `isin` on `CFTimeIndex`-backed `Coordinate` slow · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1032051447 https://github.com/pydata/xarray/issues/6230#issuecomment-1032051447 https://api.github.com/repos/pydata/xarray/issues/6230 IC_kwDOAMm_X849g9r3 shoyer 1217238 2022-02-07T23:40:48Z 2022-02-07T23:40:48Z MEMBER

In the long term (cc @benbovy) I think we would ideally split IndexVariable into two classes:

  1. FrozenVariable which is just an immutable Variable, and thus that can be safely used for coordinates that have indexes.
  2. PandasIndexArray which wraps pandas.Index objects to satisfy the np.ndarray interface. This is the object which could allow duck_array_ops.isin to use the pandas.Index.isin method.
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [PERFORMANCE]: `isin` on `CFTimeIndex`-backed `Coordinate` slow  1120583442
1032008540 https://github.com/pydata/xarray/issues/6230#issuecomment-1032008540 https://api.github.com/repos/pydata/xarray/issues/6230 IC_kwDOAMm_X849gzNc dcherian 2448579 2022-02-07T22:40:18Z 2022-02-07T22:40:18Z MEMBER

Are we still removing IndexVariable? If not, we could define isin on Variable and IndexVariable and it would be quite clean.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [PERFORMANCE]: `isin` on `CFTimeIndex`-backed `Coordinate` slow  1120583442
1031811347 https://github.com/pydata/xarray/issues/6230#issuecomment-1031811347 https://api.github.com/repos/pydata/xarray/issues/6230 IC_kwDOAMm_X849gDET shoyer 1217238 2022-02-07T19:01:54Z 2022-02-07T19:01:54Z MEMBER

Oh, I guess the challenge is that apply_ufunc operates on arrays, not indexes. I'm not entirely sure how to deal with this easily....

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [PERFORMANCE]: `isin` on `CFTimeIndex`-backed `Coordinate` slow  1120583442
1031810590 https://github.com/pydata/xarray/issues/6230#issuecomment-1031810590 https://api.github.com/repos/pydata/xarray/issues/6230 IC_kwDOAMm_X849gC4e shoyer 1217238 2022-02-07T19:01:08Z 2022-02-07T19:01:08Z MEMBER

Yes, I think replacing this with something like lambda x, y: x.isin(y) if isinstance(x, pd.Index) else np.isin(x, y) could work

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [PERFORMANCE]: `isin` on `CFTimeIndex`-backed `Coordinate` slow  1120583442
1031766376 https://github.com/pydata/xarray/issues/6230#issuecomment-1031766376 https://api.github.com/repos/pydata/xarray/issues/6230 IC_kwDOAMm_X849f4Fo dcherian 2448579 2022-02-07T18:11:26Z 2022-02-07T18:11:26Z MEMBER

Do all pd.Index objects define .isin?

If so we could special case Index objects here (note duck_array_ops.isin is numpy.isin):

https://github.com/pydata/xarray/blob/d47cf0c850cb70429373782b3c1e0329d14fd05a/xarray/core/common.py#L1423-L1428

cc @shoyer

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [PERFORMANCE]: `isin` on `CFTimeIndex`-backed `Coordinate` slow  1120583442

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);