issue_comments

Table actions

6 rows where issue = 1120405560 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • [Bug]: rename_vars to dimension coordinate does not create an index · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1239197527 https://github.com/pydata/xarray/issues/6229#issuecomment-1239197527 https://api.github.com/repos/pydata/xarray/issues/6229 IC_kwDOAMm_X85J3KdX headtr1ck 43316012 2022-09-07T10:20:12Z 2022-09-07T13:21:38Z COLLABORATOR

Then feel free to close this issue with your PR :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Bug]: rename_vars to dimension coordinate does not create an index 1120405560
1239167123 https://github.com/pydata/xarray/issues/6229#issuecomment-1239167123 https://api.github.com/repos/pydata/xarray/issues/6229 IC_kwDOAMm_X85J3DCT benbovy 4160723 2022-09-07T09:51:13Z 2022-09-07T09:51:13Z MEMBER

Does it still have the asterix(*)?

Not anymore with v2022.6.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Bug]: rename_vars to dimension coordinate does not create an index 1120405560
1239152129 https://github.com/pydata/xarray/issues/6229#issuecomment-1239152129 https://api.github.com/repos/pydata/xarray/issues/6229 IC_kwDOAMm_X85J2_YB headtr1ck 43316012 2022-09-07T09:37:47Z 2022-09-07T09:37:47Z COLLABORATOR

A warning is fine by me. I did not test it so just asking: how will the renamed coord now be displayed? Does it still have the asterix(*)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Bug]: rename_vars to dimension coordinate does not create an index 1120405560
1239068974 https://github.com/pydata/xarray/issues/6229#issuecomment-1239068974 https://api.github.com/repos/pydata/xarray/issues/6229 IC_kwDOAMm_X85J2rEu benbovy 4160723 2022-09-07T08:22:43Z 2022-09-07T08:22:43Z MEMBER

I think we need to address this through a warning or error so that users can be alerted that behaviour has changed.

This is done in #6999. Would it close this issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Bug]: rename_vars to dimension coordinate does not create an index 1120405560
1091910545 https://github.com/pydata/xarray/issues/6229#issuecomment-1091910545 https://api.github.com/repos/pydata/xarray/issues/6229 IC_kwDOAMm_X85BFTuR dcherian 2448579 2022-04-07T15:57:23Z 2022-04-07T15:57:23Z MEMBER

data.rename({"c": "x"}) does not implicitly create anymore an indexed coordinate

I have code that relied on automatic index creation through rename and some downstream code broke.

I think we need to address this through a warning or error so that users can be alerted that behaviour has changed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Bug]: rename_vars to dimension coordinate does not create an index 1120405560
1039769097 https://github.com/pydata/xarray/issues/6229#issuecomment-1039769097 https://api.github.com/repos/pydata/xarray/issues/6229 IC_kwDOAMm_X849-Z4J benbovy 4160723 2022-02-15T01:58:43Z 2022-02-15T02:00:50Z MEMBER

This has been discussed in #4825.

A third option for rename{_vars} would be to rename the coordinate and its index (if any), regardless of whether the old and new names correspond to existing dimensions. We plan to drop the concept of a "dimension coordinate" with an implicit index in favor of indexes explicitly part of Xarray's data model (see https://github.com/pydata/xarray/projects/1), so that it will be possible to set indexes for non-dimension coordinates and/or set dimension coordinates without indexes.

Re your example, in #5692 data.rename({"c": "x"}) does not implicitly create anymore an indexed coordinate (no *):

```python data_renamed

<xarray.DataArray (x: 3)>

array([5, 6, 7])

Coordinates:

x (x) int64 1 2 3

```

Instead, it should be possible to directly set an index for the c coordinate without the need to rename it, e.g.,

```python

API has still to be defined

data_indexed = data.set_index("c", index_cls=xr.PandasIndex)

data_indexed.sel(c=[1, 2])

<xarray.DataArray (x: 2)>

array([5, 6])

Coordinates:

* c (x) int64 1 2

```

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [Bug]: rename_vars to dimension coordinate does not create an index 1120405560

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);