issue_comments

Table actions

8 rows where issue = 1118729170 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Xfail failing test · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1026020646 https://github.com/pydata/xarray/pull/6211#issuecomment-1026020646 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849J9Um crusaderky 6213168 2022-01-31T17:21:40Z 2022-01-31T17:21:40Z MEMBER

More than a one-off — I got them multiple times. Though they look like tests that are liable to be flaky...

They are both tests that fail on the cleanup of @gen_cluster, and specifically on check_process_leak. However, in both cases, the test itself doesn't spawn any processes. What I think is happening is that something unrelated, at some point before the failing tests, spawned a subprocess that has become unresponsive to SIGTERM. I'm updating check_process_leak to be more aggressive in the cleanup before the test.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025305914 https://github.com/pydata/xarray/pull/6211#issuecomment-1025305914 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849HO06 max-sixty 5635139 2022-01-31T01:48:56Z 2022-01-31T01:48:56Z MEMBER

RTD is being slow, but I'll merge regardless so we can return to green

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025264731 https://github.com/pydata/xarray/pull/6211#issuecomment-1025264731 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849HExb max-sixty 5635139 2022-01-30T23:59:25Z 2022-01-30T23:59:25Z MEMBER

I haven't seen them fail before - were they just flaky?

More than a one-off — I got them multiple times. Though they look like tests that are liable to be flaky...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025249089 https://github.com/pydata/xarray/pull/6211#issuecomment-1025249089 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849HA9B mathause 10194086 2022-01-30T22:38:50Z 2022-01-30T22:38:50Z MEMBER

I haven't seen them fail before - were they just flaky?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025244455 https://github.com/pydata/xarray/pull/6211#issuecomment-1025244455 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849G_0n max-sixty 5635139 2022-01-30T22:15:23Z 2022-01-30T22:15:23Z MEMBER

We have another couple of failures though. I'll xfail them but please could someone who knows the dask interface better check them out and assess if we should raise them on the dask repo?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025244352 https://github.com/pydata/xarray/pull/6211#issuecomment-1025244352 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849G_zA max-sixty 5635139 2022-01-30T22:14:46Z 2022-01-30T22:14:46Z MEMBER

Can I suggest you xfail in

No prob, you do lots!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025242330 https://github.com/pydata/xarray/pull/6211#issuecomment-1025242330 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849G_Ta mathause 10194086 2022-01-30T22:04:29Z 2022-01-30T22:04:29Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170
1025240390 https://github.com/pydata/xarray/pull/6211#issuecomment-1025240390 https://api.github.com/repos/pydata/xarray/issues/6211 IC_kwDOAMm_X849G-1G keewis 14808389 2022-01-30T21:54:03Z 2022-01-30T21:54:10Z MEMBER

makes sense, feel free to merge as soon as the CI is green. That way, we can avoid having the CI fail in other PRs (this is not just a upstream-dev issue anymore)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xfail failing test 1118729170

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);