issue_comments

Table actions

8 rows where issue = 1118168483 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1024915181 https://github.com/pydata/xarray/pull/6208#issuecomment-1024915181 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849Fvbt kmuehlbauer 5821660 2022-01-29T13:48:16Z 2022-01-29T13:48:16Z MEMBER

At least it helps to narrow down the time when this appeared in dask. AFAICT the first occurrence was in the nightly upstream-dev build #6197.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024914645 https://github.com/pydata/xarray/pull/6208#issuecomment-1024914645 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849FvTV s-weigand 9513634 2022-01-29T13:44:50Z 2022-01-29T13:44:50Z CONTRIBUTOR

That was an upstream-dev build, so it could still be a dask issue.

Ahhh I should have looked more closely.

Btw I installed an older dask version (conda install -c conda-forge dask-core=2022.1.0) and tests pass. So I guess it is an issue with dask 2022.01.1.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024910706 https://github.com/pydata/xarray/pull/6208#issuecomment-1024910706 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849FuVy mathause 10194086 2022-01-29T13:20:51Z 2022-01-29T13:20:51Z MEMBER

I am closing this because it was not the issue of the test failure you saw in #6207.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024910383 https://github.com/pydata/xarray/pull/6208#issuecomment-1024910383 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849FuQv kmuehlbauer 5821660 2022-01-29T13:18:47Z 2022-01-29T13:19:07Z MEMBER

That was an upstream-dev build, so it could still be a dask issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024898323 https://github.com/pydata/xarray/pull/6208#issuecomment-1024898323 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849FrUT s-weigand 9513634 2022-01-29T12:01:38Z 2022-01-29T12:01:38Z CONTRIBUTOR

Looks like the same error was there two days ago so it isn't dask 2022.01.1 since it only got released 16h ago

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024894364 https://github.com/pydata/xarray/pull/6208#issuecomment-1024894364 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849FqWc s-weigand 9513634 2022-01-29T11:36:14Z 2022-01-29T11:45:59Z CONTRIBUTOR

This didn't cause the packaging issue, the packaging issue was caused by #6096 and the good old "Wait this isn't a python builtin, but I have it in each environment!" Like pkg_resources which comes with setuptools, took me ages to find what was wrong back then (old setuptools version in that venv) 😅

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024888599 https://github.com/pydata/xarray/pull/6208#issuecomment-1024888599 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849Fo8X mathause 10194086 2022-01-29T10:56:43Z 2022-01-29T10:56:43Z MEMBER

Did the tests run? Close/ reopen. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483
1024887046 https://github.com/pydata/xarray/pull/6208#issuecomment-1024887046 https://api.github.com/repos/pydata/xarray/issues/6208 IC_kwDOAMm_X849FokG TomNicholas 35968931 2022-01-29T10:45:48Z 2022-01-29T10:45:48Z MEMBER

I don't really understand which line of this caused the packaging problem, but please revert what you need to to fix xarray main! We can just keep releasing new minor versions until we get it right, don't worry about that. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" 1118168483

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);