issue_comments

Table actions

10 rows where issue = 1116080396 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • MNT: prepare h5netcdf backend for (coming) change in dimension handling · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1024885290 https://github.com/pydata/xarray/pull/6200#issuecomment-1024885290 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X849FoIq mathause 10194086 2022-01-29T10:33:40Z 2022-01-29T13:20:01Z MEMBER

~Sorry @kmuehlbauer I was too fast with merging. I have to revert this (#6208) and we can do it again once #6207 is fixed.~

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1024910544 https://github.com/pydata/xarray/pull/6200#issuecomment-1024910544 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X849FuTQ mathause 10194086 2022-01-29T13:19:52Z 2022-01-29T13:19:52Z MEMBER

Sorry I was wrong - this was not the cause for the test failure. Let's keep this as is.

 
{
    "total_count": 2,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1024860403 https://github.com/pydata/xarray/pull/6200#issuecomment-1024860403 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X849FiDz mathause 10194086 2022-01-29T07:55:16Z 2022-01-29T07:55:16Z MEMBER

Thanks @kmuehlbauer! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023380783 https://github.com/pydata/xarray/pull/6200#issuecomment-1023380783 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848_40v dionhaefner 11994217 2022-01-27T16:08:50Z 2022-01-27T16:08:50Z CONTRIBUTOR

@dionhaefner

Could you please have a look at the chunksizes FutureWarnings (eg. here https://github.com/pydata/xarray/runs/4965336696?check_suite_focus=true#step:8:344).

Are the chunksizes via h5py and via h5netcdf heuristics correct?

Let's take this in https://github.com/h5netcdf/h5netcdf/issues/149.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023308804 https://github.com/pydata/xarray/pull/6200#issuecomment-1023308804 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848_nQE mathause 10194086 2022-01-27T15:07:20Z 2022-01-27T15:08:14Z MEMBER

Looks good. The remaining upstream failure does not seem to be related.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023250220 https://github.com/pydata/xarray/pull/6200#issuecomment-1023250220 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848_Y8s kmuehlbauer 5821660 2022-01-27T14:10:51Z 2022-01-27T14:10:51Z MEMBER

@mathause The fix is applied and works. We have some issues with chunking over at h5netcdf. This will be fixed after sorting this out.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023179487 https://github.com/pydata/xarray/pull/6200#issuecomment-1023179487 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848_Hrf kmuehlbauer 5821660 2022-01-27T12:58:04Z 2022-01-27T12:58:04Z MEMBER

@dionhaefner

Could you please have a look at the chunksizes FutureWarnings (eg. here https://github.com/pydata/xarray/runs/4965336696?check_suite_focus=true#step:8:344).

Are the chunksizes via h5py and via h5netcdf heuristics correct?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023104040 https://github.com/pydata/xarray/pull/6200#issuecomment-1023104040 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848-1Qo mathause 10194086 2022-01-27T11:18:07Z 2022-01-27T11:18:07Z MEMBER

Great! Thanks for the fix. Yes the string [test-upstream] has to be part of the commit message (if you have nothing new to commit you can do git commit --allow-empty -m "[test-upstream]")

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023103900 https://github.com/pydata/xarray/pull/6200#issuecomment-1023103900 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848-1Oc kmuehlbauer 5821660 2022-01-27T11:17:55Z 2022-01-27T11:17:55Z MEMBER

I'd also like to add fixes to silence new FutureWarnings emitted by h5netcdf (hence the WIP). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396
1023100530 https://github.com/pydata/xarray/pull/6200#issuecomment-1023100530 https://api.github.com/repos/pydata/xarray/issues/6200 IC_kwDOAMm_X848-0Zy kmuehlbauer 5821660 2022-01-27T11:13:42Z 2022-01-27T11:13:42Z MEMBER

@mathause Although I'm pretty sure that this fixes the upstream-dev run, it would be good to verify. Is it possible to run the upstream-dev with this PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MNT: prepare h5netcdf backend for (coming) change in dimension handling 1116080396

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);