issue_comments

Table actions

8 rows where issue = 111471076 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • roll method · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
160543349 https://github.com/pydata/xarray/issues/624#issuecomment-160543349 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE2MDU0MzM0OQ== shoyer 1217238 2015-11-30T07:22:30Z 2015-11-30T07:22:30Z MEMBER

see #666 for an implementation of roll, as well

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
159479119 https://github.com/pydata/xarray/issues/624#issuecomment-159479119 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE1OTQ3OTExOQ== rabernat 1197350 2015-11-25T03:38:57Z 2015-11-25T03:38:57Z MEMBER

Thanks for the tip! I have obviously not worked on this. Just had my last lecture of the semester today though, so maybe something will happen soon!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
159416592 https://github.com/pydata/xarray/issues/624#issuecomment-159416592 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE1OTQxNjU5Mg== shoyer 1217238 2015-11-24T21:54:11Z 2015-11-24T21:54:11Z MEMBER

I have a PR adding shift up for review in #666. I think roll could be implemented pretty similarly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
148469051 https://github.com/pydata/xarray/issues/624#issuecomment-148469051 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE0ODQ2OTA1MQ== rabernat 1197350 2015-10-15T17:41:18Z 2015-10-15T17:41:18Z MEMBER

Thanks for the advice. I'll give it a shot.

I think I will just do integer rolls for now.

Non-integer rolls or coordinate rolls are essentially interpolation. That would be something useful to have as well. But let's start small.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
148376642 https://github.com/pydata/xarray/issues/624#issuecomment-148376642 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE0ODM3NjY0Mg== darothen 4992424 2015-10-15T12:57:04Z 2015-10-15T12:57:04Z NONE

Is there another easy way to add a constant offset to all the values of a dimension (e.g. add, say, 10 meters to every value in the dimension)? I don't typically use operations like that, but I can see where they might be useful.

If not, then rolling in integer space is the way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
148276168 https://github.com/pydata/xarray/issues/624#issuecomment-148276168 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE0ODI3NjE2OA== shoyer 1217238 2015-10-15T04:12:01Z 2015-10-15T04:12:01Z MEMBER

I agree that ds.roll(time=100) seems like the more consistent syntax.

shift seems like the natural companion method to roll. It should work the same way, but insert NaNs instead of other of the arrays. No need to add shift in this PR, of course, but it's a natural follow up.

Does it makes sense to roll in integer or coordinate space? e.g., should we be able to write ds.roll(longitude=180) regardless of the actual spatial resolution? I'm thinking it's probably better to stick with integers, simply because coordinates are not necessarily evenly spaced.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
148206569 https://github.com/pydata/xarray/issues/624#issuecomment-148206569 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE0ODIwNjU2OQ== darothen 4992424 2015-10-14T21:24:35Z 2015-10-14T21:24:35Z NONE

Using an API like ds.roll(time=100) would be more consistent with other aggregation/manipulation routines, and there's nothing in @rabernat 's code that forbids that call signature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076
148175098 https://github.com/pydata/xarray/issues/624#issuecomment-148175098 https://api.github.com/repos/pydata/xarray/issues/624 MDEyOklzc3VlQ29tbWVudDE0ODE3NTA5OA== shoyer 1217238 2015-10-14T19:48:02Z 2015-10-14T19:48:02Z MEMBER

Dataset and DataArray both inherit from BaseDataObject, so that would be an appropriate place to add this method: https://github.com/xray/xray/blob/5abc994798fb773d965adccf0dd8d932357044e0/xray/core/common.py#L148

For the API design, I wonder if it would be better to use ds.roll(time=100) instead of ds.roll(100, 'time'). Thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roll method 111471076

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);