home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where issue = 110806123 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jhamman · 5 ✖

issue 1

  • numpy 1.10 compat fixes · 5 ✖

author_association 1

  • MEMBER 5
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
147512127 https://github.com/pydata/xarray/pull/618#issuecomment-147512127 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzUxMjEyNw== jhamman 2443309 2015-10-12T20:32:42Z 2015-10-12T20:32:42Z MEMBER

Okay - that worked. I think we're good with numpy 1.10 here. There is still one failing test related to pandas/numpy. This may be more of a travis thing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  numpy 1.10 compat fixes 110806123
147490424 https://github.com/pydata/xarray/pull/618#issuecomment-147490424 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzQ5MDQyNA== jhamman 2443309 2015-10-12T18:53:47Z 2015-10-12T18:53:47Z MEMBER

ugh indeed. I'll figure out how to coerce the datetime64 object into something that works for now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  numpy 1.10 compat fixes 110806123
147142725 https://github.com/pydata/xarray/pull/618#issuecomment-147142725 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzE0MjcyNQ== jhamman 2443309 2015-10-11T01:08:01Z 2015-10-11T01:08:01Z MEMBER

I'm actually going to paste the traceback from one of the test results (using py.test) to show how nonsensical this is:

``` =========================================================================================================== FAILURES ============================================================================================================ _____________ TestVariable.test_index_0d_not_a_time _____________

self = <xray.test.test_variable.TestVariable testMethod=test_index_0d_not_a_time>

def test_index_0d_not_a_time(self):
    d = np.datetime64('NaT')
    x = self.cls(['x'], [d])
    # Wasn't able to figure out why this was failing.
    # AssertionError: numpy.datetime64('NaT') != numpy.datetime64('NaT')
  self.assertIndexedLikeNDArray(x, d, None)

xray/test/test_variable.py:115:


xray/test/test_variable.py:61: in assertIndexedLikeNDArray self.assertEqual(variable.values[0], expected_value0)


self = <xray.test.test_variable.TestVariable testMethod=test_index_0d_not_a_time>, a1 = numpy.datetime64('NaT'), a2 = numpy.datetime64('NaT')

def assertEqual(self, a1, a2):
  assert a1 == a2 or (a1 != a1 and a2 != a2)

E AssertionError: assert (numpy.datetime64('NaT') == numpy.datetime64('NaT') or (numpy.datetime64('NaT') != numpy.datetime64('NaT')))

xray/test/init.py:154: AssertionError ```

I don't get how neither of these are true:

(numpy.datetime64('NaT') == numpy.datetime64('NaT') or\ (numpy.datetime64('NaT') != numpy.datetime64('NaT')))

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  numpy 1.10 compat fixes 110806123
147142509 https://github.com/pydata/xarray/pull/618#issuecomment-147142509 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzE0MjUwOQ== jhamman 2443309 2015-10-11T00:59:04Z 2015-10-11T00:59:04Z MEMBER

Previously, NaT == NaT was true. Now it's false, like how NaN works.

@shoyer - I don't think this is true.

``` Python In [9]: import numpy as np

In [10]: t = np.datetime64('NaT')

In [11]: t == t Out[11]: True

In [12]: n = np.nan

In [13]: n == n Out[13]: False

In [14]: np.version Out[14]: '1.10.0' ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  numpy 1.10 compat fixes 110806123
147130696 https://github.com/pydata/xarray/pull/618#issuecomment-147130696 https://api.github.com/repos/pydata/xarray/issues/618 MDEyOklzc3VlQ29tbWVudDE0NzEzMDY5Ng== jhamman 2443309 2015-10-10T22:30:22Z 2015-10-10T22:30:22Z MEMBER

I'll figure out something to do with the NaT comparison.

I think we're okay on Travis. We just have one failing test.

As for the verbosity of the numpy warnings. It is now just showing up in a lot more places (https://travis-ci.org/xray/xray/jobs/84683346#L665-L702). It seems like matplotlib and numpy itself haven't dealt with the warnings on their end yet.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  numpy 1.10 compat fixes 110806123

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 65.496ms · About: xarray-datasette