issue_comments

Table actions

4 rows where issue = 1098924491 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Use base ImportError not MoudleNotFoundError when testing for plugins · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1009823872 https://github.com/pydata/xarray/pull/6154#issuecomment-1009823872 https://api.github.com/repos/pydata/xarray/issues/6154 IC_kwDOAMm_X848MLCA hmaarrfk 90008 2022-01-11T10:28:51Z 2022-01-11T10:28:51Z CONTRIBUTOR

Thanks for merging so quickly

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use base ImportError not MoudleNotFoundError when testing for plugins 1098924491
1009820327 https://github.com/pydata/xarray/pull/6154#issuecomment-1009820327 https://api.github.com/repos/pydata/xarray/issues/6154 IC_kwDOAMm_X848MKKn max-sixty 5635139 2022-01-11T10:24:53Z 2022-01-11T10:24:53Z MEMBER

Thank you @hmaarrfk , that makes a lot of sense.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use base ImportError not MoudleNotFoundError when testing for plugins 1098924491
1009802137 https://github.com/pydata/xarray/pull/6154#issuecomment-1009802137 https://api.github.com/repos/pydata/xarray/issues/6154 IC_kwDOAMm_X848MFuZ hmaarrfk 90008 2022-01-11T10:14:09Z 2022-01-11T10:14:09Z CONTRIBUTOR

ImportError is a superset of ModuleNotFoundError. https://github.com/python/cpython/blob/f4c03484da59049eb62a9bf7777b963e2267d187/Lib/test/exception_hierarchy.txt#L19

So it depends what question you care about asking:

  1. Does the python exist? You should test for ModuleNotFoundError
  2. Is the package usable? You should probably test for ImportError

I think question 2 is friendlier to xarray users.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use base ImportError not MoudleNotFoundError when testing for plugins 1098924491
1009795612 https://github.com/pydata/xarray/pull/6154#issuecomment-1009795612 https://api.github.com/repos/pydata/xarray/issues/6154 IC_kwDOAMm_X848MEIc max-sixty 5635139 2022-01-11T10:10:19Z 2022-01-11T10:10:19Z MEMBER

Thanks @hmaarrfk !

Is there any tradeoff here or is your proposal always better?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use base ImportError not MoudleNotFoundError when testing for plugins 1098924491

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);