issue_comments

Table actions

5 rows where issue = 109583455 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Add subplot_kws arg to plotting interfaces · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
263807796 https://github.com/pydata/xarray/pull/604#issuecomment-263807796 https://api.github.com/repos/pydata/xarray/issues/604 MDEyOklzc3VlQ29tbWVudDI2MzgwNzc5Ng== cwerner 13906519 2016-11-30T08:00:48Z 2016-11-30T08:00:48Z NONE

Hi.

I'm seeing the same plotting issues as @jhamman in the plot above Oct 2015 with 0.8.2. Basically, all (most?) operations on the first subplots' axis differ.

Is there a fix/ workaround for this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add subplot_kws arg to plotting interfaces 109583455
145211793 https://github.com/pydata/xarray/pull/604#issuecomment-145211793 https://api.github.com/repos/pydata/xarray/issues/604 MDEyOklzc3VlQ29tbWVudDE0NTIxMTc5Mw== jhamman 2443309 2015-10-03T07:31:07Z 2015-10-03T07:31:07Z MEMBER

@shoyer - Thanks for taking a look. I'm going to leave the subplot_kws=None for consistency with Seaborn (not a big deal, I know) and because the tests started to hang when I changed this to a empty dict.

I'm going to open another PR to address the aspect and alignment when using Cartopy.

@clarkfitzg - Good luck on those quals. I've got to say, they weren't my favorite moments of grad school.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add subplot_kws arg to plotting interfaces 109583455
145186575 https://github.com/pydata/xarray/pull/604#issuecomment-145186575 https://api.github.com/repos/pydata/xarray/issues/604 MDEyOklzc3VlQ29tbWVudDE0NTE4NjU3NQ== shoyer 1217238 2015-10-03T00:13:32Z 2015-10-03T00:13:32Z MEMBER

LGTM

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add subplot_kws arg to plotting interfaces 109583455
145186449 https://github.com/pydata/xarray/pull/604#issuecomment-145186449 https://api.github.com/repos/pydata/xarray/issues/604 MDEyOklzc3VlQ29tbWVudDE0NTE4NjQ0OQ== clarkfitzg 5356122 2015-10-03T00:11:42Z 2015-10-03T00:11:42Z MEMBER

This looks good. The general strategy with the FacetGrid was to bring the minimum amount of code in from Seaborn to make it do what we wanted. I see no issues in iterating like this, ie. bring in pieces of the code with tests as we need them.

Side note- I'm back in grad school studying for qualifying exams, so forgive me if it takes me a while to respond in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add subplot_kws arg to plotting interfaces 109583455
145186360 https://github.com/pydata/xarray/pull/604#issuecomment-145186360 https://api.github.com/repos/pydata/xarray/issues/604 MDEyOklzc3VlQ29tbWVudDE0NTE4NjM2MA== shoyer 1217238 2015-10-03T00:10:25Z 2015-10-03T00:10:25Z MEMBER

Very nice!

I wonder if we could default to something like aspect=None, which indicates that the native aspect should be used for plots that supply a projection.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add subplot_kws arg to plotting interfaces 109583455

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);