issue_comments

Table actions

5 rows where issue = 109018309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • unsorted integer indexing on netCDF4 objections on disk · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
145161500 https://github.com/pydata/xarray/pull/595#issuecomment-145161500 https://api.github.com/repos/pydata/xarray/issues/595 MDEyOklzc3VlQ29tbWVudDE0NTE2MTUwMA== jhamman 2443309 2015-10-02T21:41:09Z 2015-10-02T21:41:09Z MEMBER

Updated that comment. Merging now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unsorted integer indexing on netCDF4 objections on disk 109018309
145135160 https://github.com/pydata/xarray/pull/595#issuecomment-145135160 https://api.github.com/repos/pydata/xarray/issues/595 MDEyOklzc3VlQ29tbWVudDE0NTEzNTE2MA== shoyer 1217238 2015-10-02T19:37:03Z 2015-10-02T19:37:03Z MEMBER

Yep, works for me. Probably a good idea to add a comment to that effect to the skipped test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unsorted integer indexing on netCDF4 objections on disk 109018309
145129683 https://github.com/pydata/xarray/pull/595#issuecomment-145129683 https://api.github.com/repos/pydata/xarray/issues/595 MDEyOklzc3VlQ29tbWVudDE0NTEyOTY4Mw== jhamman 2443309 2015-10-02T19:16:01Z 2015-10-02T19:16:01Z MEMBER

Okay, that makes sense. Well this done. I'll merge this evening if there are no objections.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unsorted integer indexing on netCDF4 objections on disk 109018309
145118890 https://github.com/pydata/xarray/pull/595#issuecomment-145118890 https://api.github.com/repos/pydata/xarray/issues/595 MDEyOklzc3VlQ29tbWVudDE0NTExODg5MA== shoyer 1217238 2015-10-02T18:39:30Z 2015-10-02T18:39:30Z MEMBER

@jhamman Yep, dask rewrites indexers to getitem. In the case of unsorted indexers, it currently pulls out items by block first: https://github.com/blaze/dask/blob/de3633b2693e67f0acccebda4dfc58332aefb527/dask/array/slicing.py#L461

Wrapping all netCDF4 variables with dask.array might be a viable work around for the netCDF4-python issue, if we make dask a required dependency. We'll probably want to do that after https://github.com/blaze/dask/issues/746 is fixed anyways, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unsorted integer indexing on netCDF4 objections on disk 109018309
144928525 https://github.com/pydata/xarray/pull/595#issuecomment-144928525 https://api.github.com/repos/pydata/xarray/issues/595 MDEyOklzc3VlQ29tbWVudDE0NDkyODUyNQ== jhamman 2443309 2015-10-02T05:34:43Z 2015-10-02T05:34:43Z MEMBER

@shoyer - This could use a quick review when you get a chance. For one reason or another, the IndexError is not raised when using dask so I've skipped over it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   unsorted integer indexing on netCDF4 objections on disk 109018309

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);