issue_comments

Table actions

5 rows where issue = 1087126812 and user = 1562854 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • jklymak · 5 ✖

issue 1

  • Regression in datetime handling in plots · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1003563370 https://github.com/pydata/xarray/issues/6102#issuecomment-1003563370 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X8470Slq jklymak 1562854 2022-01-01T14:02:31Z 2022-01-01T14:02:31Z CONTRIBUTOR 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812
1003558439 https://github.com/pydata/xarray/issues/6102#issuecomment-1003558439 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X8470RYn jklymak 1562854 2022-01-01T13:20:08Z 2022-01-01T13:20:08Z CONTRIBUTOR

BTW, maybe you could/should add a test for this behaviour? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812
1003558389 https://github.com/pydata/xarray/issues/6102#issuecomment-1003558389 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X8470RX1 jklymak 1562854 2022-01-01T13:19:39Z 2022-01-01T13:19:39Z CONTRIBUTOR

I checked the code from above, and it has the Matplotlib unit handlers rather than the pandas

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812
1002699860 https://github.com/pydata/xarray/issues/6102#issuecomment-1002699860 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X847w_xU jklymak 1562854 2021-12-29T17:25:01Z 2021-12-29T17:25:01Z CONTRIBUTOR

As I'm away from a computer for a few days so can't double check, but I did bisect the problem to the pr that was reverted.

However you could keep this open for a more fulsome discussion of date handling and whether xarray wants to use the pandas or matplotlib converters. I would actually be pretty happy if pandas also just used matplotlibs converters - we already jump through some hoops to make data frames work. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812
1000287742 https://github.com/pydata/xarray/issues/6102#issuecomment-1000287742 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X847ny3- jklymak 1562854 2021-12-23T13:00:28Z 2021-12-23T13:00:28Z CONTRIBUTOR

Hi @Illviljan that is correct. However after https://github.com/pydata/xarray/pull/5794 xarray is more aggressively making the pandas choice for the user.

I'll play with it a bit to see if just removing your explicit registration fixes the problem. However changing the datetime converter would be a breaking change (to your plotting) that I'm not sure you want.

This is a tricky problem that I'm not sure matplotlib has handled properly (full disclosure, I'm on the mpl dev team and usually handle datetime issues, though I didn't design our units registry). Having a registry that users can change is very flexible. However when downstream libraries like xarray or pandas affect user plotting just by importing the package, it leads to considerable confusion as users don't necessarily know this has happened or how to get back to the Matplotlib default. Particularly if they are not using the package's plotting utilities, but just the other features and/or data types (for instance I love xarray and use it all the time in my data analysis, but I rarely use the plotting convenience functions)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);