issue_comments

Table actions

3 rows where issue = 1084220684 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Type protocol for internal variable mapping · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
998528889 https://github.com/pydata/xarray/pull/6086#issuecomment-998528889 https://api.github.com/repos/pydata/xarray/issues/6086 IC_kwDOAMm_X847hFd5 max-sixty 5635139 2021-12-21T07:12:40Z 2021-12-21T07:12:40Z MEMBER

I realize that my assertion above isn't quite right — the issue was about Mapping[Hashable, V], not Dict[Hashable, V].

I'm thinking through this issue. I think the basic problem is that these CopyableMutableMapping aren't dict objects — given we can't inherit from dict (or Mapping) — and possibly we'd need to change our interface to CopyableMutableMapping for this to work. I'm not confident about this, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type protocol for internal variable mapping 1084220684
998221530 https://github.com/pydata/xarray/pull/6086#issuecomment-998221530 https://api.github.com/repos/pydata/xarray/issues/6086 IC_kwDOAMm_X847f6ba max-sixty 5635139 2021-12-20T19:48:44Z 2021-12-20T19:48:44Z MEMBER

I can have a look this week! Would you mind committing the Hashable -> Any changes? I'm confident that's the correct approach — we went through this at length on the main codebase — even if it doesn't fix all the probs...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type protocol for internal variable mapping 1084220684
997501156 https://github.com/pydata/xarray/pull/6086#issuecomment-997501156 https://api.github.com/repos/pydata/xarray/issues/6086 IC_kwDOAMm_X847dKjk max-sixty 5635139 2021-12-20T00:53:59Z 2021-12-20T00:53:59Z MEMBER

To comment quickly (but incompletely atm) — Dict[Hashable, X] doesn't work well with mypy because Dict is invariant in its keys (I think) — it needs to be Dict[Any, X]

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type protocol for internal variable mapping 1084220684

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);