issue_comments

Table actions

7 rows where issue = 108271509 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • New encoding keyword argument for to_netcdf · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
146385570 https://github.com/pydata/xarray/pull/589#issuecomment-146385570 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0NjM4NTU3MA== jhamman 2443309 2015-10-08T00:58:59Z 2015-10-08T00:58:59Z MEMBER

Looks good to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509
146371615 https://github.com/pydata/xarray/pull/589#issuecomment-146371615 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0NjM3MTYxNQ== shoyer 1217238 2015-10-08T00:06:57Z 2015-10-08T00:06:57Z MEMBER

@jhamman I think fixed the things you pointed out.

@ocefpaf I agree with you about decode_cf. I'm going to leave the current name for now, but we should change/deprecate it in v0.7.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509
143335054 https://github.com/pydata/xarray/pull/589#issuecomment-143335054 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0MzMzNTA1NA== ocefpaf 950575 2015-09-25T19:44:36Z 2015-09-25T19:44:36Z CONTRIBUTOR

single option for open_dataset that can disable all of xray's decoding options

I get that and I really like this option!

Not sure about raw=False

:+1: decode=True

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509
143334183 https://github.com/pydata/xarray/pull/589#issuecomment-143334183 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0MzMzNDE4Mw== shoyer 1217238 2015-09-25T19:40:33Z 2015-09-25T19:40:33Z MEMBER

I believe fill values, packing/unpacking and time units are all included in CF conventions by reference, but I agree that the name decode_cf may be confusing. The issue is that I want a practical single option for open_dataset that can disable all of xray's decoding options (which don't always work), just so the data can be examined. These conventions include NUG, COORDS, CF and even some xray specific conventions (so far, only for encoding coordinates without data variables).

Perhaps rather than decode_cf=True, we should have raw=False or decode=True?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509
143302566 https://github.com/pydata/xarray/pull/589#issuecomment-143302566 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0MzMwMjU2Ng== ocefpaf 950575 2015-09-25T17:52:19Z 2015-09-25T17:52:19Z CONTRIBUTOR

This is similar to the situation with Unicode strings and bytes.

That comparison is what I meant. The concept is the same, as you said, but what comes to mind is the unicode/bytes situation and not netCDF compression and the various conventions.

I guess that what I do not like in the docs is the fact that compression and conventions are bagged together as "encoding." I see compression as "encoding," but I cannot see all the conventions as encoding . Also, encoding or not, those are not CF rules to be called decode_cf. (But reading the CF-conventions usually gives me a headache so I might be wrong.)

Anyway, the docs are good and understandable,. My comments above are just minor issues I have with CF, NUG, and netCDF writing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509
143299023 https://github.com/pydata/xarray/pull/589#issuecomment-143299023 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0MzI5OTAyMw== shoyer 1217238 2015-09-25T17:40:36Z 2015-09-25T17:40:36Z MEMBER

@ocefpaf could you elaborate a little bit on why you think encoding could be confusing to Pythonistas? To me, the word makes sense because the data can be "coded" on disk according to various conventions and compression settings. This is similar to the situation with Unicode strings and bytes -- you can encode Unicode in various ways into bytes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509
143183227 https://github.com/pydata/xarray/pull/589#issuecomment-143183227 https://api.github.com/repos/pydata/xarray/issues/589 MDEyOklzc3VlQ29tbWVudDE0MzE4MzIyNw== ocefpaf 950575 2015-09-25T10:29:59Z 2015-09-25T10:29:59Z CONTRIBUTOR

Hi @shoyer I read the docs and I think it is pretty good. I am just not comfortable with the word encoding? That might confuse Pythonistas. Also decode_cf=True means a lot more than missing data (_FillValue), packing/unpacking (scale_factor/add_offset) [1] and dates parsing (which we inherited from the terrible COARDS but that is not the point here).

In fact the first two are netCDF features older than CF and they are described in the NetCDF User's Guide (sometimes called the "NUG") [2].

It is ugly but why not decode_nug=True?

[1] http://cfconventions.org/Data/cf-conventions/cf-conventions-1.6/build/cf-conventions.html#terminology

[2] http://www.unidata.ucar.edu/software/netcdf/docs/netcdf.html#Attribute-Conventions

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New encoding keyword argument for to_netcdf 108271509

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);