issue_comments

Table actions

11 rows where issue = 1062681040 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • REF: Make mypy manual stage with pre-commit · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1033335868 https://github.com/pydata/xarray/pull/6024#issuecomment-1033335868 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X849l3Q8 max-sixty 5635139 2022-02-09T04:28:51Z 2022-02-09T04:28:51Z MEMBER

Thanks a lot @snowman2 !

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
1030701879 https://github.com/pydata/xarray/pull/6024#issuecomment-1030701879 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X849b0M3 snowman2 8699967 2022-02-05T21:29:03Z 2022-02-05T21:29:03Z CONTRIBUTOR

No worries. I will try to address the conflicts when I get a free moment. Though, I wouldn't complain if someone else with a sooner free moment finished this one off before I do :-).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
1030695475 https://github.com/pydata/xarray/pull/6024#issuecomment-1030695475 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X849byoz max-sixty 5635139 2022-02-05T20:41:14Z 2022-02-05T20:41:14Z MEMBER

I'm sorry this dropped. Could we resolve conflicts and then merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978665769 https://github.com/pydata/xarray/pull/6024#issuecomment-978665769 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846VUEp max-sixty 5635139 2021-11-25T00:57:50Z 2021-11-25T00:57:50Z MEMBER

OK, I'd vote to merge this, leave the existing CI job, and then remove it when pre-commit.ci allows running manual stages. One of the main benefits of pre-commit.ci is that it adds changes to the branch, which doesn't help for mypy anyway.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978097496 https://github.com/pydata/xarray/pull/6024#issuecomment-978097496 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846TJVY snowman2 8699967 2021-11-24T17:47:21Z 2021-11-24T17:47:21Z CONTRIBUTOR

can we make it?

I am not seeing an option to do that: https://pre-commit.ci/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978094247 https://github.com/pydata/xarray/pull/6024#issuecomment-978094247 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846TIin max-sixty 5635139 2021-11-24T17:42:46Z 2021-11-24T17:42:46Z MEMBER

Ah — one thing to check — I'm not sure it's running in https://results.pre-commit.ci/run/github/13221727/1637775215.Vi4gz7adRWeUAsEu1oJeZA — can we make it? We were hoping to replace the existing CI job with this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978093218 https://github.com/pydata/xarray/pull/6024#issuecomment-978093218 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846TISi snowman2 8699967 2021-11-24T17:41:22Z 2021-11-24T17:41:22Z CONTRIBUTOR

Is mypy being run in the CI now?

Yes, it runs on the CI

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978092217 https://github.com/pydata/xarray/pull/6024#issuecomment-978092217 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846TIC5 Illviljan 14371165 2021-11-24T17:39:46Z 2021-11-24T17:39:46Z MEMBER

Is mypy being run in the CI now? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978088422 https://github.com/pydata/xarray/pull/6024#issuecomment-978088422 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846THHm snowman2 8699967 2021-11-24T17:34:12Z 2021-11-24T17:34:12Z CONTRIBUTOR

I didn't know we could pass --all like that.

I think it is equivalent to --all-files

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978083626 https://github.com/pydata/xarray/pull/6024#issuecomment-978083626 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846TF8q dcherian 2448579 2021-11-24T17:27:43Z 2021-11-24T17:27:43Z MEMBER

I like this! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040
978082934 https://github.com/pydata/xarray/pull/6024#issuecomment-978082934 https://api.github.com/repos/pydata/xarray/issues/6024 IC_kwDOAMm_X846TFx2 max-sixty 5635139 2021-11-24T17:26:51Z 2021-11-24T17:26:51Z MEMBER

Thanks @snowman2 .

This is excellent! I didn't know we could pass --all like that.

I'm a :+1:. Can we update the PR template to include that flag?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   REF: Make mypy manual stage with pre-commit 1062681040

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);