issue_comments

Table actions

6 rows where issue = 1057355557 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Added test for issue #6002 (currently fails) · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
981408883 https://github.com/pydata/xarray/pull/6003#issuecomment-981408883 https://api.github.com/repos/pydata/xarray/issues/6003 IC_kwDOAMm_X846fxxz RubendeBruin 34062862 2021-11-29T08:49:02Z 2021-11-29T08:49:02Z NONE

"does that work on your end?"

yes it does. Will remove the xfail and then we can merge once https://github.com/pydata/bottleneck/pull/382 is merged.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added test for issue #6002 (currently fails) 1057355557
979412541 https://github.com/pydata/xarray/pull/6003#issuecomment-979412541 https://api.github.com/repos/pydata/xarray/issues/6003 IC_kwDOAMm_X846YKY9 max-sixty 5635139 2021-11-25T18:22:47Z 2021-11-25T18:22:47Z MEMBER

@RubendeBruin it seems my guidance was bad — the test failures suggest that because this is a segfault xfail doesn't work, because the whole program crashes.

So instead, let's leave this open until bottleneck does a release, and then merge this as a passing test — does that work on your end?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added test for issue #6002 (currently fails) 1057355557
979285475 https://github.com/pydata/xarray/pull/6003#issuecomment-979285475 https://api.github.com/repos/pydata/xarray/issues/6003 IC_kwDOAMm_X846XrXj RubendeBruin 34062862 2021-11-25T15:03:17Z 2021-11-25T15:03:17Z NONE

I've added xfail , thanks for the link.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added test for issue #6002 (currently fails) 1057355557
979242142 https://github.com/pydata/xarray/pull/6003#issuecomment-979242142 https://api.github.com/repos/pydata/xarray/issues/6003 IC_kwDOAMm_X846Xgye max-sixty 5635139 2021-11-25T14:05:10Z 2021-11-25T14:05:10Z MEMBER

Hi @max-sixty , what is a xfail ?

https://docs.pytest.org/en/6.2.x/skipping.html — it marks the test as "expected failure".

Also, the issue turned out to be bottleneck-bug , ref: pydata/bottleneck#393 (comment) (fix available)

Great that it's fixed upstream! We can either wait for it to be released and then merge this, or merge this now with the xfail

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added test for issue #6002 (currently fails) 1057355557
979146287 https://github.com/pydata/xarray/pull/6003#issuecomment-979146287 https://api.github.com/repos/pydata/xarray/issues/6003 IC_kwDOAMm_X846XJYv RubendeBruin 34062862 2021-11-25T12:01:38Z 2021-11-25T12:01:38Z NONE

Hi @max-sixty , what is a xfail ?

Also, the issue turned out to be bottleneck-bug , ref: https://github.com/pydata/bottleneck/issues/393#issuecomment-978017397 (fix available)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added test for issue #6002 (currently fails) 1057355557
973230283 https://github.com/pydata/xarray/pull/6003#issuecomment-973230283 https://api.github.com/repos/pydata/xarray/issues/6003 IC_kwDOAMm_X846AlDL max-sixty 5635139 2021-11-18T20:20:56Z 2021-11-18T20:20:56Z MEMBER

Great! If you add an xfail we can merge...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added test for issue #6002 (currently fails) 1057355557

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);