issue_comments

Table actions

6 rows where issue = 105673104 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Adding a generalized 1D plotting function · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
315174338 https://github.com/pydata/xarray/pull/566#issuecomment-315174338 https://api.github.com/repos/pydata/xarray/issues/566 MDEyOklzc3VlQ29tbWVudDMxNTE3NDMzOA== shoyer 1217238 2017-07-13T19:11:32Z 2017-07-13T19:11:32Z MEMBER

More 1D plots goes in the "nice to have" category for me. I don't think @drewokane is planning to pick this up, so let's close for now. But if anyone is interested in picking this up, please feel free to use this as the basis for a new PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding a generalized 1D plotting function 105673104
315169627 https://github.com/pydata/xarray/pull/566#issuecomment-315169627 https://api.github.com/repos/pydata/xarray/issues/566 MDEyOklzc3VlQ29tbWVudDMxNTE2OTYyNw== jhamman 2443309 2017-07-13T18:53:22Z 2017-07-13T18:53:22Z MEMBER

Is this a feature we're still interested in getting in? It seems like this was pretty close but its been sitting here for almost 2 years.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding a generalized 1D plotting function 105673104
141567421 https://github.com/pydata/xarray/pull/566#issuecomment-141567421 https://api.github.com/repos/pydata/xarray/issues/566 MDEyOklzc3VlQ29tbWVudDE0MTU2NzQyMQ== drewokane 9342082 2015-09-18T20:57:33Z 2015-09-18T20:57:33Z NONE

The only error left that is failing is testing if the ylabel in the histogram contains the word 'Count'. If we're moving towards a generalized plotting function, we need to rethink labeling the axes. Thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding a generalized 1D plotting function 105673104
140237861 https://github.com/pydata/xarray/pull/566#issuecomment-140237861 https://api.github.com/repos/pydata/xarray/issues/566 MDEyOklzc3VlQ29tbWVudDE0MDIzNzg2MQ== clarkfitzg 5356122 2015-09-15T00:10:19Z 2015-09-15T00:10:19Z MEMBER

Still need tests for these. It would be possible to do something like test_plots.Common2dMixin here, or do something more direct.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding a generalized 1D plotting function 105673104
140233372 https://github.com/pydata/xarray/pull/566#issuecomment-140233372 https://api.github.com/repos/pydata/xarray/issues/566 MDEyOklzc3VlQ29tbWVudDE0MDIzMzM3Mg== shoyer 1217238 2015-09-14T23:35:18Z 2015-09-14T23:35:18Z MEMBER

@drewokane yes, these errors look relevant:

```

ERROR: test_format_string (xray.test.test_plot.TestPlot1D)

Traceback (most recent call last): File "/home/travis/build/xray/xray/xray/test/test_plot.py", line 136, in test_format_string self.darray.plot.line('ro') File "/home/travis/build/xray/xray/xray/plot/plot.py", line 523, in line return _plotter_1d(self._da, plot_method='plot', args, *kwargs) TypeError: _plotter_1d() got multiple values for keyword argument 'plot_method' ====================================================================== ERROR: test_3d_array (xray.test.test_plot.TestPlotHistogram)

Traceback (most recent call last): File "/home/travis/build/xray/xray/xray/test/test_plot.py", line 174, in test_3d_array self.darray.plot.hist() File "/home/travis/build/xray/xray/xray/plot/plot.py", line 517, in hist return _plotter_data(self._da, plot_method='hist', **kwargs) File "/home/travis/build/xray/xray/xray/plot/plot.py", line 307, in _plotter_data 'dimensions'.format(ndims=ndims)) ValueError: Line plots are for 1 dimensional DataArrays. Passed DataArray has 3 dimensions ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding a generalized 1D plotting function 105673104
140233059 https://github.com/pydata/xarray/pull/566#issuecomment-140233059 https://api.github.com/repos/pydata/xarray/issues/566 MDEyOklzc3VlQ29tbWVudDE0MDIzMzA1OQ== drewokane 9342082 2015-09-14T23:32:38Z 2015-09-14T23:32:38Z NONE

Do I need to address the Travis-CI errors?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding a generalized 1D plotting function 105673104

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);