issue_comments

Table actions

4 rows where issue = 1051772149 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Allow string formatting of scalar DataArrays · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1121248195 https://github.com/pydata/xarray/pull/5981#issuecomment-1121248195 https://api.github.com/repos/pydata/xarray/issues/5981 IC_kwDOAMm_X85C1OPD Illviljan 14371165 2022-05-09T15:25:25Z 2022-05-09T15:25:25Z MEMBER

Thanks @fmaussion!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow string formatting of scalar DataArrays 1051772149
1116275051 https://github.com/pydata/xarray/pull/5981#issuecomment-1116275051 https://api.github.com/repos/pydata/xarray/issues/5981 IC_kwDOAMm_X85CiQFr fmaussion 10050469 2022-05-03T16:08:37Z 2022-05-03T16:08:37Z MEMBER

@Illviljan and other devs - I still think this small change would be a nice addition for accessibility and teaching. Let me know if we can purse or if I should close this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow string formatting of scalar DataArrays 1051772149
974864775 https://github.com/pydata/xarray/pull/5981#issuecomment-974864775 https://api.github.com/repos/pydata/xarray/issues/5981 IC_kwDOAMm_X846G0GH fmaussion 10050469 2021-11-21T17:59:22Z 2021-11-21T17:59:22Z MEMBER

Side note: with this design (no call to repr() in format()) we would mimick numpy's behavior:

python a = np.array([0.1, 0.2]) a.__format__("") Out[16]: '[0.1 0.2]' a.__repr__() Out[17]: 'array([0.1, 0.2])'

However I'm quite surprised as to why .__format__("") works on non-scalar arrays but not with other specifiers - this is discussed somehow in https://github.com/numpy/numpy/issues/5543 . I think it's okay for xarray to defer to whatever numpy is doing here, but of course we can also keep the status-quo, it's quite a small change after all. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow string formatting of scalar DataArrays 1051772149
966987656 https://github.com/pydata/xarray/pull/5981#issuecomment-966987656 https://api.github.com/repos/pydata/xarray/issues/5981 IC_kwDOAMm_X845ow-I fmaussion 10050469 2021-11-12T10:21:34Z 2021-11-12T11:04:58Z MEMBER

Note that there would be a way to change the behavior to:

python print(da) -> lengthy repr print('{}'.format(da) -> fall back to numpy.__format__

This would break backwards compatibility, but I think it would be my preference - there are some chances that it brakes some code (in documentation pages maybe?), but I don't think that many people rely on '{}'.format(da) to return __repr__ ...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow string formatting of scalar DataArrays 1051772149

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);