issue_comments

Table actions

5 rows where issue = 1051487078 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Fix mypy issue with entry_points · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
967321272 https://github.com/pydata/xarray/pull/5979#issuecomment-967321272 https://api.github.com/repos/pydata/xarray/issues/5979 IC_kwDOAMm_X845qCa4 max-sixty 5635139 2021-11-12T18:19:03Z 2021-11-12T18:19:03Z MEMBER

(tbc, no strong view on the exact form here — I merged just so we had a clean branch — very happy to anyone to make any other changes)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix mypy issue with entry_points 1051487078
967303973 https://github.com/pydata/xarray/pull/5979#issuecomment-967303973 https://api.github.com/repos/pydata/xarray/issues/5979 IC_kwDOAMm_X845p-Ml Illviljan 14371165 2021-11-12T17:52:20Z 2021-11-12T17:52:20Z MEMBER

I suppose the try/except is the issue. I think the If-check seems clearer, since we then know when to remove it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix mypy issue with entry_points 1051487078
967288853 https://github.com/pydata/xarray/pull/5979#issuecomment-967288853 https://api.github.com/repos/pydata/xarray/issues/5979 IC_kwDOAMm_X845p6gV kmuehlbauer 5821660 2021-11-12T17:28:12Z 2021-11-12T17:28:12Z MEMBER

I'll have a look how this resolved, since I've copied that in #5959. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix mypy issue with entry_points 1051487078
967286271 https://github.com/pydata/xarray/pull/5979#issuecomment-967286271 https://api.github.com/repos/pydata/xarray/issues/5979 IC_kwDOAMm_X845p53_ kmuehlbauer 5821660 2021-11-12T17:24:14Z 2021-11-12T17:24:14Z MEMBER

@Illviljan Maybe because this one here is in try/except? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix mypy issue with entry_points 1051487078
966843270 https://github.com/pydata/xarray/pull/5979#issuecomment-966843270 https://api.github.com/repos/pydata/xarray/issues/5979 IC_kwDOAMm_X845oNuG Illviljan 14371165 2021-11-12T05:56:03Z 2021-11-12T05:56:03Z MEMBER

Why is the ignore even needed? We do this on other places without an issue: https://github.com/pydata/xarray/blob/b1392d03d5081c04b8188f4a92a8d4a95fea1b51/xarray/core/npcompat.py#L42-L45

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix mypy issue with entry_points 1051487078

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);