issue_comments

Table actions

6 rows where issue = 1046625905 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • pre-commit: autoupdate hook versions · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
963647475 https://github.com/pydata/xarray/pull/5949#issuecomment-963647475 https://api.github.com/repos/pydata/xarray/issues/5949 IC_kwDOAMm_X845cBfz keewis 14808389 2021-11-08T22:54:37Z 2021-11-08T22:54:37Z MEMBER

I can remove this GHA if so...

yes, please. If we agree that pre-commit.ci is the way forward we can definitely remove the old update CI (see also https://github.com/pydata/xarray/issues/5940#issuecomment-961767895)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-commit: autoupdate hook versions 1046625905
963570677 https://github.com/pydata/xarray/pull/5949#issuecomment-963570677 https://api.github.com/repos/pydata/xarray/issues/5949 IC_kwDOAMm_X845buv1 max-sixty 5635139 2021-11-08T21:03:33Z 2021-11-08T21:03:33Z MEMBER

IIUC, https://github.com/pydata/xarray/pull/5955 is a better version of this GHA, and runs tests because it's a PR rather than a workflow. Is that right? I can remove this GHA if so...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-commit: autoupdate hook versions 1046625905
962900040 https://github.com/pydata/xarray/pull/5949#issuecomment-962900040 https://api.github.com/repos/pydata/xarray/issues/5949 IC_kwDOAMm_X845ZLBI keewis 14808389 2021-11-08T08:02:46Z 2021-11-08T08:02:46Z MEMBER

It didn't run the tests for some reason

github workflows can't trigger other workflow runs with the default token (secrets.GITHUB_TOKEN). I didn't know that manually reopening would make it run, though.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-commit: autoupdate hook versions 1046625905
962580689 https://github.com/pydata/xarray/pull/5949#issuecomment-962580689 https://api.github.com/repos/pydata/xarray/issues/5949 IC_kwDOAMm_X845X9DR github-actions[bot] 41898282 2021-11-07T09:50:13Z 2021-11-07T09:50:13Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   55m 38s :stopwatch: +24s 16 290 tests ±0  14 551 :heavy_check_mark:  - 1  1 739 :zzz: +1  0 :x: ±0  90 936 runs  ±0  82 738 :heavy_check_mark:  - 1  8 198 :zzz: +1  0 :x: ±0 

Results for commit f206ee24. ± Comparison against base commit 402a9b39.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-commit: autoupdate hook versions 1046625905
962579750 https://github.com/pydata/xarray/pull/5949#issuecomment-962579750 https://api.github.com/repos/pydata/xarray/issues/5949 IC_kwDOAMm_X845X80m Illviljan 14371165 2021-11-07T09:42:52Z 2021-11-07T09:42:52Z MEMBER

@max-sixty It didn't run the tests for some reason. But now those tests are indeed crashing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-commit: autoupdate hook versions 1046625905
962559571 https://github.com/pydata/xarray/pull/5949#issuecomment-962559571 https://api.github.com/repos/pydata/xarray/issues/5949 IC_kwDOAMm_X845X35T max-sixty 5635139 2021-11-07T06:31:14Z 2021-11-07T06:31:14Z MEMBER

I would have thought that the isort: skip would be necessary, and this would cause the tests to fail... And unsure why it's not skipped with this upgrade!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-commit: autoupdate hook versions 1046625905

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);