issue_comments

Table actions

6 rows where issue = 1043746973 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Reimplement `.polyfit()` with `apply_ufunc` · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1016816597 https://github.com/pydata/xarray/pull/5933#issuecomment-1016816597 https://api.github.com/repos/pydata/xarray/issues/5933 IC_kwDOAMm_X848m2PV Illviljan 14371165 2022-01-19T19:54:49Z 2022-01-19T19:54:49Z MEMBER

I think you can use a lot of @dcherian's code as a base and then for starters see if it simply passes all the tests (including the ones you added here). If you make a draft PR here it's easier to help out as well if you're getting stuck.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reimplement `.polyfit()` with `apply_ufunc` 1043746973
1016805677 https://github.com/pydata/xarray/pull/5933#issuecomment-1016805677 https://api.github.com/repos/pydata/xarray/issues/5933 IC_kwDOAMm_X848mzkt slevang 39069044 2022-01-19T19:39:57Z 2022-01-19T19:39:57Z CONTRIBUTOR

Not sure I understand the blockwise approach well enough to make a PR, but maybe I'll give it a try at some point.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reimplement `.polyfit()` with `apply_ufunc` 1043746973
1016791909 https://github.com/pydata/xarray/pull/5933#issuecomment-1016791909 https://api.github.com/repos/pydata/xarray/issues/5933 IC_kwDOAMm_X848mwNl Illviljan 14371165 2022-01-19T19:21:56Z 2022-01-19T19:21:56Z MEMBER

@slevang Yeah, the blockwise approach seems indeed nice. You're very welcome to continue with the blockwise approach in a different PR if you want to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reimplement `.polyfit()` with `apply_ufunc` 1043746973
1015887354 https://github.com/pydata/xarray/pull/5933#issuecomment-1015887354 https://api.github.com/repos/pydata/xarray/issues/5933 IC_kwDOAMm_X848jTX6 slevang 39069044 2022-01-18T22:21:49Z 2022-01-18T22:45:16Z CONTRIBUTOR

@slevang are you still interested to continue this PR? I think that would be a worthwhile addition and should not be too much left to do. (What would be nice, however, are tests for the issues this fixes.)

Definitely! I got distracted is all, and @dcherian posted a nice solution in #5629 that could allow us to preserve the ability to fit along a chunked dimension using blockwise operations and the dask lstsq implementation used by the existing polyfit code.

I'm happy to pick this back up and finish it off if there is consensus on the right way forward, but the blockwise approach seemed promising so I put this on hold. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reimplement `.polyfit()` with `apply_ufunc` 1043746973
1015866453 https://github.com/pydata/xarray/pull/5933#issuecomment-1015866453 https://api.github.com/repos/pydata/xarray/issues/5933 IC_kwDOAMm_X848jORV mathause 10194086 2022-01-18T21:50:48Z 2022-01-18T21:50:48Z MEMBER

@slevang are you still interested to continue this PR? I think that would be a worthwhile addition and should not be too much left to do. (What would be nice, however, are tests for the issues this fixes.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reimplement `.polyfit()` with `apply_ufunc` 1043746973
959541609 https://github.com/pydata/xarray/pull/5933#issuecomment-959541609 https://api.github.com/repos/pydata/xarray/issues/5933 IC_kwDOAMm_X845MXFp github-actions[bot] 41898282 2021-11-03T15:56:14Z 2021-11-03T15:56:14Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   58m 4s :stopwatch: 16 290 tests 14 551 :heavy_check_mark: 1 739 :zzz: 0 :x: 90 936 runs  82 738 :heavy_check_mark: 8 198 :zzz: 0 :x:

Results for commit 62b4637d.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reimplement `.polyfit()` with `apply_ufunc` 1043746973

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);