issue_comments

Table actions

8 rows where issue = 1043378880 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • fix the detection of backend entrypoints · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
959728744 https://github.com/pydata/xarray/pull/5931#issuecomment-959728744 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845NExo dcherian 2448579 2021-11-03T16:55:50Z 2021-11-03T16:55:50Z MEMBER

Great. Thanks @tdhopper . I'm merging now and will open an issue to add tests for this feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
959724275 https://github.com/pydata/xarray/pull/5931#issuecomment-959724275 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845NDrz tdhopper 611122 2021-11-03T16:50:43Z 2021-11-03T16:50:43Z NONE

This fixes an issue I was having with cfgrib in 0.20.0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
959353310 https://github.com/pydata/xarray/pull/5931#issuecomment-959353310 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845LpHe dcherian 2448579 2021-11-03T15:00:53Z 2021-11-03T15:00:53Z MEMBER

@ashwinvis Does your package work with this PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
959131968 https://github.com/pydata/xarray/pull/5931#issuecomment-959131968 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845KzFA ashwinvis 9155111 2021-11-03T13:52:26Z 2021-11-03T13:54:22Z CONTRIBUTOR

Or add a small dummy package to be installed using pip while testing. Something like the following under the ci/requirements/*.yml files should do it.

yml - pip: - ./xarray_test_package

with the following contents at ci/requirements at the bare minimum ```ini ❯ cat xarray_test_package/pyproject.toml [build-system] requires = ["setuptools", "wheel"] build-backend = "setuptools.build_meta" ❯ cat xarray_test_package/setup.cfg [metadata] name = xarray_test_package version = 0.0.0

[options] packages = find:

[options.entry_points] xarray.backends = xarray_test_package_backend = xarray_test_package.plugin:XarrayTestPackageBackend ```

This can later be extended with a minimal xarray_test_package.plugin module if needed.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
959052834 https://github.com/pydata/xarray/pull/5931#issuecomment-959052834 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845Kfwi dcherian 2448579 2021-11-03T13:18:00Z 2021-11-03T13:18:00Z MEMBER

For now we could test against rioxarray? Or publish a new package to conda-forge just for testing this feature? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
958995873 https://github.com/pydata/xarray/pull/5931#issuecomment-958995873 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845KR2h keewis 14808389 2021-11-03T12:42:35Z 2021-11-03T12:54:10Z MEMBER

the only way I can think of is to somehow install a test package providing an entrypoint, check that it's in the list of detected engines and remove it again. However, installing within the test suite is fragile so we might have to monkeypatch something within importlib.metadata to have the same effect – wrap entry_points to add the test, maybe?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
958988982 https://github.com/pydata/xarray/pull/5931#issuecomment-958988982 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845KQK2 dcherian 2448579 2021-11-03T12:32:23Z 2021-11-03T12:32:23Z MEMBER

Can we test this somehow? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880
958903776 https://github.com/pydata/xarray/pull/5931#issuecomment-958903776 https://api.github.com/repos/pydata/xarray/issues/5931 IC_kwDOAMm_X845J7Xg github-actions[bot] 41898282 2021-11-03T10:52:42Z 2021-11-03T11:27:21Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   55m 29s :stopwatch: 16 290 tests 14 557 :heavy_check_mark: 1 733 :zzz: 0 :x: 90 936 runs  82 744 :heavy_check_mark: 8 192 :zzz: 0 :x:

Results for commit fb6113cb.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix the detection of backend entrypoints 1043378880

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);