issue_comments

Table actions

7 rows where issue = 1043276928 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Regression: 3rd party backends are not discovered with `xarray==0.20.0` · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
966171905 https://github.com/pydata/xarray/issues/5930#issuecomment-966171905 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845lp0B kmuehlbauer 5821660 2021-11-11T10:06:47Z 2021-11-11T10:06:47Z MEMBER

Thanks @da-wad. We have to wait a bit until #5959 gets reviewed again. If the reviewers are happy with the current state of the PR a 0.20.2 could be released as fast as 0.20.1. :crossed_fingers: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928
966166870 https://github.com/pydata/xarray/issues/5930#issuecomment-966166870 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845lolW da-wad 25386679 2021-11-11T10:00:11Z 2021-11-11T10:00:11Z NONE

Nice work, @kmuehlbauer ! #5959 does fix the issue I was experiencing - thanks! Hope we get a 0.20.2 with that soon...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928
966109773 https://github.com/pydata/xarray/issues/5930#issuecomment-966109773 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845lapN kmuehlbauer 5821660 2021-11-11T09:02:11Z 2021-11-11T09:02:11Z MEMBER

@da-wad I have the same issues. It looks like that the call to pytestadds the package under test to the list of distributions. This results in a duplication of the entrypoints. During the switch from pkg_resources to importlib.metadata there were changes missed to apply in remove_duplicates function.

You can try to test #5959, where I hopefully fixed all issues.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928
966106093 https://github.com/pydata/xarray/issues/5930#issuecomment-966106093 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845lZvt da-wad 25386679 2021-11-11T08:56:36Z 2021-11-11T08:56:36Z NONE

I think this might not actually be fixed... I now get a different error from xarray==0.20.1 than I did from xarray==0.20.0 : Appveyor

entrypoints seems to have two instances of my backend, and is appears to be attempting to differentiate them using an attribute called module_name... but I can't see how to set that, or how it would be different between the duplicates...?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928
959723922 https://github.com/pydata/xarray/issues/5930#issuecomment-959723922 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845NDmS tdhopper 611122 2021-11-03T16:50:17Z 2021-11-03T16:50:17Z NONE

😅 Good catch. I was getting an error with cfgrib not recognizing kwargs, and it's this same issue. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928
958877280 https://github.com/pydata/xarray/issues/5930#issuecomment-958877280 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845J05g keewis 14808389 2021-11-03T10:40:32Z 2021-11-03T10:40:32Z MEMBER

thanks for the report, @ashwinvis, that's indeed a bug in the new version, specifically here: https://github.com/pydata/xarray/blob/960010b00119367ff6b82e548f2b54ca25c7a59c/xarray/backends/plugins.py#L102-L106 The issue is that that code assumes the backends are in the "xarray" distribution, in a module called "xarray.backends". That's not true, though: the distribution for third-party backends is the third-party library, and we're actually looking for all entrypoints in the "xarray.backends" group. Thus, the code should actually be: python entrypoints = entry_points().get("xarray.backends", ())

I've opened a PR to fix this: #5931

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928
958787822 https://github.com/pydata/xarray/issues/5930#issuecomment-958787822 https://api.github.com/repos/pydata/xarray/issues/5930 IC_kwDOAMm_X845JfDu ashwinvis 9155111 2021-11-03T09:43:29Z 2021-11-03T09:43:29Z CONTRIBUTOR

In the same example 1st party backends such as h5netcdf work with both versions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression: 3rd party backends are not discovered with `xarray==0.20.0` 1043276928

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);